Ruff fixes for Python 3.14 and Ruff 0.14.2

Author: jb3

bot/__init__.py

@@ -17,4 +17,4 @@
 
 apply_monkey_patches()
 
-instance: "Bot" = None  # Global Bot instance.
+instance: Bot = None  # Global Bot instance.

bot/exts/backend/sync/_syncers.py

@@ -225,10 +225,10 @@ async def _sync(diff: _Diff) -> None:
         # Using asyncio.gather would still consume too many resources on the site.
         log.trace("Syncing created users...")
         if diff.created:
-            for chunk in batched(diff.created, CHUNK_SIZE):
+            for chunk in batched(diff.created, CHUNK_SIZE, strict=False):
                 await bot.instance.api_client.post("bot/users", json=chunk)
 
         log.trace("Syncing updated users...")
         if diff.updated:
-            for chunk in batched(diff.updated, CHUNK_SIZE):
+            for chunk in batched(diff.updated, CHUNK_SIZE, strict=False):
                 await bot.instance.api_client.patch("bot/users/bulk_patch", json=chunk)

bot/exts/filtering/_filter_lists/antispam.py

@@ -40,7 +40,7 @@ class AntispamList(UniquesListBase):
 
     name = "antispam"
 
-    def __init__(self, filtering_cog: "Filtering"):
+    def __init__(self, filtering_cog: Filtering):
         super().__init__(filtering_cog)
         self.message_deletion_queue: dict[Member, DeletionContext] = dict()
 

bot/exts/filtering/_filter_lists/filter_list.py

@@ -90,7 +90,7 @@ async def _create_filter_list_result(
         self, ctx: FilterContext, defaults: Defaults, filters: Iterable[Filter]
     ) -> list[Filter]:
         """A helper function to evaluate the result of `filter_list_result`."""
-        passed_by_default, failed_by_default = defaults.validations.evaluate(ctx)
+        _passed_by_default, failed_by_default = defaults.validations.evaluate(ctx)
         default_answer = not bool(failed_by_default)
 
         relevant_filters = []
@@ -160,7 +160,7 @@ def __hash__(self):
 T = typing.TypeVar("T", bound=Filter)
 
 
-class FilterList(dict[ListType, AtomicList], typing.Generic[T], FieldRequiring):
+class FilterList[T](dict[ListType, AtomicList], FieldRequiring):
     """Dispatches events to lists of _filters, and aggregates the responses into a single list of actions to take."""
 
     # Each subclass must define a name matching the filter_list name we're expecting to receive from the database.
@@ -268,7 +268,7 @@ class UniquesListBase(FilterList[UniqueFilter], ABC):
     Each unique filter subscribes to a subset of events to respond to.
     """
 
-    def __init__(self, filtering_cog: "Filtering"):
+    def __init__(self, filtering_cog: Filtering):
         super().__init__()
         self.filtering_cog = filtering_cog
         self.loaded_types: dict[str, type[UniqueFilter]] = {}

bot/exts/filtering/_ui/filter.py

@@ -293,7 +293,7 @@ async def update_embed(
         if setting_name:
             # Find the right dictionary to update.
             if "/" in setting_name:
-                filter_name, setting_name = setting_name.split("/", maxsplit=1)
+                _filter_name, setting_name = setting_name.split("/", maxsplit=1)
                 dict_to_edit = self.filter_settings_overrides
                 default_value = self.filter_type.extra_fields_type().model_dump()[setting_name]
             else:

bot/exts/filtering/_ui/search.py

@@ -114,7 +114,7 @@ def template_settings(
     result = get_filter(filter_id, filter_lists)
     if not result:
         raise BadArgument(f"Could not find a filter with ID `{filter_id}`.")
-    filter_, filter_list, list_type = result
+    filter_, _filter_list, _list_type = result
 
     if filter_type and not isinstance(filter_, filter_type):
         raise BadArgument(f"The filter with ID `{filter_id}` is not of type {filter_type.name!r}.")
@@ -256,7 +256,7 @@ async def update_embed(
             return
 
         if "/" in setting_name:
-            filter_name, setting_name = setting_name.split("/", maxsplit=1)
+            _filter_name, setting_name = setting_name.split("/", maxsplit=1)
             dict_to_edit = self.filter_settings
         else:
             dict_to_edit = self.settings

bot/exts/filtering/_ui/ui.py

@@ -136,7 +136,7 @@ def populate_embed_from_dict(embed: Embed, data: dict) -> None:
         embed.add_field(name=setting, value=value, inline=len(value) < MAX_INLINE_SIZE)
 
 
-def parse_value(value: str, type_: type[T]) -> T:
+def parse_value[T](value: str, type_: type[T]) -> T:
     """Parse the value provided in the CLI and attempt to convert it to the provided type."""
     blank = value == '""'
     type_ = normalize_type(type_, prioritize_nonetype=blank)

bot/exts/filtering/_utils.py

@@ -34,7 +34,7 @@
 Serializable = bool | int | float | str | list | dict | None
 
 
-def subclasses_in_package(package: str, prefix: str, parent: T) -> set[T]:
+def subclasses_in_package[T](package: str, prefix: str, parent: T) -> set[T]:
     """Return all the subclasses of class `parent`, found in the top-level of `package`, given by absolute path."""
     subclasses = set()
 
@@ -157,7 +157,7 @@ def normalize_type(type_: type, *, prioritize_nonetype: bool = True) -> type:
     return type_
 
 
-def starting_value(type_: type[T]) -> T:
+def starting_value[T](type_: type[T]) -> T:
     """Return a value of the given type."""
     type_ = normalize_type(type_)
     try:

bot/exts/recruitment/talentpool/_cog.py

@@ -41,7 +41,7 @@ class NominationContextModal(discord.ui.Modal, title="New Nomination"):
         max_length=REASON_MAX_CHARS - 110
     )
 
-    def __init__(self, cog: "TalentPool", message: discord.Message, noms_channel: discord.TextChannel):
+    def __init__(self, cog: TalentPool, message: discord.Message, noms_channel: discord.TextChannel):
         self.message = message
         self.api = cog.api
         self.noms_channel = noms_channel

bot/exts/utils/reminders.py

@@ -82,7 +82,7 @@ async def cancel(self, interaction: Interaction, button: discord.ui.Button) -> N
 class OptInReminderMentionView(discord.ui.View):
     """A button to opt-in to get notified of someone else's reminder."""
 
-    def __init__(self, cog: "Reminders", reminder: dict, expiration: Duration):
+    def __init__(self, cog: Reminders, reminder: dict, expiration: Duration):
         super().__init__()
 
         self.cog = cog