Merge pull request #1105 from srowe/make-run_editor-public

Make _run_editor() public

Author: tleonhardt

cmd2/cmd2.py

@@ -4389,7 +4389,7 @@ def do_history(self, args: argparse.Namespace) -> Optional[bool]:
                     else:
                         fobj.write(f'{command.raw}\n')
             try:
-                self._run_editor(fname)
+                self.run_editor(fname)
                 # noinspection PyTypeChecker
                 self.do_run_script(utils.quote_string(fname))
             finally:
@@ -4632,9 +4632,9 @@ def _generate_transcript(self, history: Union[List[HistoryItem], List[str]], tra
     @with_argparser(edit_parser)
     def do_edit(self, args: argparse.Namespace) -> None:
         """Run a text editor and optionally open a file with it"""
-        self._run_editor(args.file_path)
+        self.run_editor(args.file_path)
 
-    def _run_editor(self, file_path: Optional[str]) -> None:
+    def run_editor(self, file_path: Optional[str]) -> None:
         """
         Run a text editor and optionally open a file with it
 

tests/test_history.py

@@ -544,9 +544,9 @@ def test_history_edit(monkeypatch):
     # going to call it due to the mock
     app.editor = 'fooedit'
 
-    # Mock out the _run_editor call so we don't actually open an editor
-    edit_mock = mock.MagicMock(name='_run_editor')
-    monkeypatch.setattr("cmd2.Cmd._run_editor", edit_mock)
+    # Mock out the run_editor call so we don't actually open an editor
+    edit_mock = mock.MagicMock(name='run_editor')
+    monkeypatch.setattr("cmd2.Cmd.run_editor", edit_mock)
 
     # Mock out the run_script call since the mocked edit won't produce a file
     run_script_mock = mock.MagicMock(name='do_run_script')