Merge pull request #13723 from bluetech/approx-mapping-len

python_api: improve approx assert message on mappings with only extra elements

Author: bluetech

changelog/13722.bugfix.rst

@@ -0,0 +1 @@
+Fixed a misleading assertion failure message when using :func:`pytest.approx` on mappings with differing lengths.

src/_pytest/python_api.py

@@ -236,6 +236,12 @@ def __repr__(self) -> str:
     def _repr_compare(self, other_side: Mapping[object, float]) -> list[str]:
         import math
 
+        if len(self.expected) != len(other_side):
+            return [
+                "Impossible to compare mappings with different sizes.",
+                f"Lengths: {len(self.expected)} and {len(other_side)}",
+            ]
+
         approx_side_as_map = {
             k: self._approx_scalar(v) for k, v in self.expected.items()
         }

testing/python/approx.py

@@ -741,6 +741,17 @@ def test_dict_for_div_by_zero(self, assert_approx_raises_regex):
             ],
         )
 
+    def test_dict_differing_lengths(self, assert_approx_raises_regex):
+        assert_approx_raises_regex(
+            {"a": 0},
+            {"a": 0, "b": 1},
+            [
+                "  ",
+                r"  Impossible to compare mappings with different sizes\.",
+                r"  Lengths: 2 and 1",
+            ],
+        )
+
     def test_numpy_array(self):
         np = pytest.importorskip("numpy")