Skip to content

Commit 95e0cf2

Browse files
committed
config: rename MyOptionParser -> PytestArgumentParser
Initially wanted to rename it to `MyArgumentParser` to make it clearer it's an `argparse.ArgumentParser`. But "My" looks funny, so change to `Pytest` similar to `PytestPluginManager`.
1 parent b7e9612 commit 95e0cf2

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/_pytest/config/argparsing.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,10 @@ def parse(
115115
strargs = [os.fspath(x) for x in args]
116116
return self.optparser.parse_args(strargs, namespace=namespace)
117117

118-
def _getparser(self) -> MyOptionParser:
118+
def _getparser(self) -> PytestArgumentParser:
119119
from _pytest._argcomplete import filescompleter
120120

121-
optparser = MyOptionParser(self, self.extra_info, prog=self.prog)
121+
optparser = PytestArgumentParser(self, self.extra_info, prog=self.prog)
122122
groups = [*self._groups, self._anonymous]
123123
for group in groups:
124124
if group.options:
@@ -437,7 +437,7 @@ def _addoption_instance(self, option: Argument, shortupper: bool = False) -> Non
437437
self.options.append(option)
438438

439439

440-
class MyOptionParser(argparse.ArgumentParser):
440+
class PytestArgumentParser(argparse.ArgumentParser):
441441
def __init__(
442442
self,
443443
parser: Parser,

src/_pytest/helpconfig.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
from _pytest.config import Config
1414
from _pytest.config import ExitCode
1515
from _pytest.config import PrintHelp
16-
from _pytest.config.argparsing import MyOptionParser
1716
from _pytest.config.argparsing import Parser
17+
from _pytest.config.argparsing import PytestArgumentParser
1818
from _pytest.terminal import TerminalReporter
1919
import pytest
2020

@@ -51,7 +51,7 @@ def __call__(
5151
setattr(namespace, self.dest, self.const)
5252

5353
# We should only skip the rest of the parsing after preparse is done.
54-
assert isinstance(parser, MyOptionParser)
54+
assert isinstance(parser, PytestArgumentParser)
5555
if getattr(parser._parser, "after_preparse", False):
5656
raise PrintHelp
5757

0 commit comments

Comments
 (0)