Merge pull request #107 from altendky/also_test_pyside2

also test pyside2

Author: altendky

.github/workflows/ci.yml

@@ -72,8 +72,11 @@ jobs:
           - name: default
             tox: default
             dependencies: default
-          - name: Qt5
-            tox: qt5
+          - name: PyQt5
+            tox: pyqt5
+            dependencies: qt5
+          - name: PySide2
+            tox: pyside2
             dependencies: qt5
           - name: asyncio
             tox: asyncio
@@ -82,7 +85,11 @@ jobs:
           - python:
               tox: py27
             reactor:
-              tox: qt5
+              tox: pyqt5
+          - python:
+              tox: py27
+            reactor:
+              tox: pyside2
           - python:
               tox: py27
             reactor:
@@ -94,11 +101,19 @@ jobs:
           - python:
               tox: pypy2
             reactor:
-              tox: qt5
+              tox: pyqt5
+          - python:
+              tox: pypy2
+            reactor:
+              tox: pyside2
+          - python:
+              tox: pypy3
+            reactor:
+              tox: pyqt5
           - python:
               tox: pypy3
             reactor:
-              tox: qt5
+              tox: pyside2
     steps:
       - uses: actions/checkout@v2
       - name: Enable Problem Matchers

appveyor.yml

@@ -1,3 +1,5 @@
+image: Visual Studio 2019
+
 environment:
   VENV: "%APPVEYOR_BUILD_FOLDER%\\venv"
 
@@ -8,28 +10,28 @@ environment:
     - TOXENV: py27-defaultreactor
       PYTHON: "C:\\Python27-x64"
 
-    - TOXENV: py35-defaultreactor, py35-qt5reactor, py35-asyncioreactor
+    - TOXENV: py35-defaultreactor, py35-pyqt5reactor, py35-pyside2reactor, py35-asyncioreactor
       PYTHON: "C:\\Python35"
 
-    - TOXENV: py35-defaultreactor, py35-qt5reactor, py35-asyncioreactor
+    - TOXENV: py35-defaultreactor, py35-pyqt5reactor, py35-pyside2reactor, py35-asyncioreactor
       PYTHON: "C:\\Python35-x64"
 
-    - TOXENV: py36-defaultreactor, py36-qt5reactor, py36-asyncioreactor
+    - TOXENV: py36-defaultreactor, py36-pyqt5reactor, py36-pyside2reactor, py36-asyncioreactor
       PYTHON: "C:\\Python36"
 
-    - TOXENV: py36-defaultreactor, py36-qt5reactor, py36-asyncioreactor
+    - TOXENV: py36-defaultreactor, py36-pyqt5reactor, py36-pyside2reactor, py36-asyncioreactor
       PYTHON: "C:\\Python36-x64"
 
-    - TOXENV: py37-defaultreactor, py37-qt5reactor, py37-asyncioreactor
+    - TOXENV: py37-defaultreactor, py37-pyqt5reactor, py37-pyside2reactor, py37-asyncioreactor
       PYTHON: "C:\\Python37"
 
-    - TOXENV: py37-defaultreactor, py37-qt5reactor, py37-asyncioreactor
+    - TOXENV: py37-defaultreactor, py37-pyqt5reactor, py37-pyside2reactor, py37-asyncioreactor
       PYTHON: "C:\\Python37-x64"
 
-    - TOXENV: py38-defaultreactor, py38-qt5reactor, py38-asyncioreactor
+    - TOXENV: py38-defaultreactor, py38-pyqt5reactor, py38-pyside2reactor, py38-asyncioreactor
       PYTHON: "C:\\Python38"
 
-    - TOXENV: py38-defaultreactor, py38-qt5reactor, py38-asyncioreactor
+    - TOXENV: py38-defaultreactor, py38-pyqt5reactor, py38-pyside2reactor, py38-asyncioreactor
       PYTHON: "C:\\Python38-x64"
 
 install:

setup.py

@@ -17,8 +17,11 @@
     install_requires=["greenlet", "pytest>=2.3", "decorator"],
     extras_require={
         "dev": ["pre-commit", "black"],
-        "pyside2": ["pyside2", "qt5reactor"],
-        "pyqt5": ["pyqt5", "qt5reactor>=0.6.2"],
+        "pyside2": [
+            # >= 0.6.3 for PySide2 extra version constraints
+            "qt5reactor[pyside2]>=0.6.3",
+        ],
+        "pyqt5": ["qt5reactor[pyqt5]>=0.6.2"],
     },
     classifiers=[
         "Development Status :: 5 - Production/Stable",

tox.ini

@@ -2,24 +2,25 @@
 envlist=
     py{27,py2,35,36,37,38,py3}-defaultreactor
     py{35,36,37,38,py3}-asyncioreactor
-    py{35,36,37,38}-qt5reactor
+    py{35,36,37,38}-pyqt5reactor
+    py{35,36,37,38}-pyside2reactor
     linting
 
 [testenv]
 deps=
     greenlet
     pytest
     twisted
-    qt5reactor: pytest-qt
-    qt5reactor: qt5reactor
-    qt5reactor: pytest-xvfb
-    qt5reactor: pyqt5
-    qt5reactor: pywin32; sys_platform == 'win32'
+    pyqt5reactor,pyside2reactor: pytest-qt
+    pyqt5reactor,pyside2reactor: pytest-xvfb
+    pyqt5reactor,pyside2reactor: pywin32; sys_platform == 'win32'
 extras=
-    qt5reactor: pyqt5
+    pyqt5reactor: pyqt5
+    pyside2reactor: pyside2
 setenv=
     defaultreactor: REACTOR = default
-    qt5reactor: REACTOR = qt5reactor
+    pyqt5reactor: REACTOR = qt5reactor
+    pyside2reactor: REACTOR = qt5reactor
     asyncioreactor: REACTOR = asyncio
 commands=
     pytest --reactor={env:REACTOR}