F

Author: CarstenGrohmann

test/test_modules.py

@@ -137,6 +137,7 @@ def test_service_systemd_mask(host, docker_image):
     assert not ssh.is_masked
 
 
+@all_images
 def test_service_systemd_ssh(host, docker_image):
     name = "sshd" if docker_image == "rockylinux9" else "ssh"
     ssh = host.service(name)
@@ -149,19 +150,23 @@ def test_service_systemd_ssh(host, docker_image):
 @pytest.mark.testinfra_hosts("docker://rockylinux9")
 def test_service_systemd_root_mount(host):
     root = host.service("-.mount")  # systemd unit for mounting /
-    assert root.exists
-    assert root.is_valid
-    assert root.is_enabled
-    assert root.is_running
+    x = host.run("systemctl status -- -.mount")
+    raise AssertionError(f"{x.stdout}\n{x.stderr}")
+    # assert root.exists
+    # x = root.is_valid
+    # raise AssertionError(f"{x}")
+    # assert root.is_valid
+    # assert root.is_enabled
+    # assert root.is_running
 
 
 @pytest.mark.testinfra_hosts("docker://rockylinux9")
 def test_service_systemd_tmp_mount(host):
     tmp = host.service("tmp.mount")
     assert tmp.exists
     assert tmp.is_valid
-    assert tmp.is_enabled
-    assert tmp.is_running
+    assert not tmp.is_enabled
+    assert not tmp.is_running
 
 
 def test_salt(host):

testinfra/modules/service.py

@@ -176,8 +176,14 @@ def _has_systemd_suffix(self):
 
     @property
     def exists(self):
-        cmd = self.run_test('systemctl list-unit-files | grep -q -- "^%s"', self.name)
-        return cmd.rc == 0
+        # systemctl return codes based on https://man7.org/linux/man-pages/man1/systemctl.1.html:
+        # 0: unit is active
+        # 1: unit not failed (used by is-failed)
+        # 2: unused
+        # 3: unit is not active
+        # 4: no such unit
+        cmd = self.run_expect([0, 1, 3, 4], "systemctl status -- %s", self.name)
+        return cmd.rc < 4
 
     @property
     def is_running(self):