Selenium 4.0 (#265)

* Support Selenium 4

Co-authored-by: dosas <dosas@github.com>

Author: dosas

pytest_selenium/drivers/cloud.py

@@ -17,11 +17,18 @@ class Provider(object):
     def name(self):
         return type(self).__name__
 
+    @property
+    def config_name(self):
+        return ".{0}".format(self.name.lower())
+
+    @property
+    def config_file_path(self):
+        return os.path.join(os.path.expanduser("~"), self.config_name)
+
     @property
     def config(self):
-        name = ".{0}".format(self.name.lower())
         config = configparser.ConfigParser()
-        config.read([name, os.path.join(os.path.expanduser("~"), name)])
+        config.read([self.config_name, self.config_file_path])
         return config
 
     def get_credential(self, key, envs):

setup.cfg

@@ -35,7 +35,8 @@ install_requires =
     pytest-base-url
     pytest-html>=1.14.0
     pytest-variables>=1.5.0
-    selenium>=3.0.0,<4.0.0
+    selenium>=3.0.0,<4.0.0;python_version=='3.6'
+    selenium>=4.0.0;python_version>'3.6'
     requests
     tenacity>=6.0.0,<7.0.0
 python_requires = >=3.6.1

testing/conftest.py

@@ -28,10 +28,11 @@ def testdir(request, httpserver_base_url):
 
     conftest = """
         import pytest
+        from selenium.webdriver.common.by import By
         @pytest.fixture
         def webtext(base_url, selenium):
             selenium.get(base_url)
-            return selenium.find_element_by_tag_name('h1').text
+            return selenium.find_element(By.TAG_NAME, 'h1').text
         """
 
     if item.get_closest_marker("chrome"):
@@ -51,9 +52,13 @@ def chrome_options(chrome_options):
         filterwarnings =
             error::DeprecationWarning
             ignore:--firefox-\w+ has been deprecated:DeprecationWarning
+            ignore:capabilities and desired_capabilities have been deprecated, please pass in a Service object:DeprecationWarning
+            ignore:firefox_profile has been deprecated, please use an Options object:DeprecationWarning
+            ignore:Setting a profile has been deprecated. Please use the set_preference and install_addons methods:DeprecationWarning
+            ignore:Getting a profile has been deprecated.:DeprecationWarning
             ignore:desired_capabilities has been deprecated
             ignore:service_log_path has been deprecated
-    """,
+    """,  # noqa: E501
     )
 
     def runpytestqa(*args, **kwargs):

testing/test_browserstack.py

@@ -7,6 +7,8 @@
 
 import pytest
 
+from pytest_selenium.drivers.cloud import Provider
+
 pytestmark = pytest.mark.nondestructive
 
 
@@ -66,7 +68,6 @@ def test_missing_access_key_file(failure, monkeypatch, tmpdir):
     ],
 )
 def test_invalid_credentials_env(failure, monkeypatch, tmpdir, username, key):
-    monkeypatch.setattr(os.path, "expanduser", lambda p: str(tmpdir))
     monkeypatch.setenv(username, "foo")
     monkeypatch.setenv(key, "bar")
     out = failure()
@@ -75,8 +76,9 @@ def test_invalid_credentials_env(failure, monkeypatch, tmpdir, username, key):
 
 
 def test_invalid_credentials_file(failure, monkeypatch, tmpdir):
-    monkeypatch.setattr(os.path, "expanduser", lambda p: str(tmpdir))
-    tmpdir.join(".browserstack").write("[credentials]\nusername=foo\nkey=bar")
+    cfg_file = tmpdir.join(".browserstack")
+    cfg_file.write("[credentials]\nusername=foo\nkey=bar")
+    monkeypatch.setattr(Provider, "config_file_path", str(cfg_file))
     out = failure()
     messages = ["Invalid username or password", "basic auth failed"]
     assert any(message in out for message in messages)

testing/test_firefox.py

@@ -49,11 +49,12 @@ def test_profile(testdir, httpserver):
     file_test = testdir.makepyfile(
         """
         import pytest
+        from selenium.webdriver.common.by import By
         @pytest.mark.nondestructive
         def test_profile(base_url, selenium):
             selenium.get(base_url)
-            header = selenium.find_element_by_tag_name('h1')
-            anchor = selenium.find_element_by_tag_name('a')
+            header = selenium.find_element(By.TAG_NAME, 'h1')
+            anchor = selenium.find_element(By.TAG_NAME, 'a')
             header_color = header.value_of_css_property('color')
             anchor_color = anchor.value_of_css_property('color')
             assert header_color == 'rgb(255, 0, 0)'
@@ -81,11 +82,12 @@ def test_profile_with_preferences(testdir, httpserver):
     file_test = testdir.makepyfile(
         """
         import pytest
+        from selenium.webdriver.common.by import By
         @pytest.mark.nondestructive
         def test_preferences(base_url, selenium):
             selenium.get(base_url)
-            header = selenium.find_element_by_tag_name('h1')
-            anchor = selenium.find_element_by_tag_name('a')
+            header = selenium.find_element(By.TAG_NAME, 'h1')
+            anchor = selenium.find_element(By.TAG_NAME, 'a')
             header_color = header.value_of_css_property('color')
             anchor_color = anchor.value_of_css_property('color')
             assert header_color == 'rgb(255, 0, 0)'
@@ -114,6 +116,7 @@ def test_extension(testdir):
         """
         import time
         import pytest
+        from selenium.webdriver.common.by import By
         from selenium.common.exceptions import StaleElementReferenceException
         from selenium.webdriver.support.ui import WebDriverWait
         @pytest.mark.nondestructive
@@ -122,7 +125,7 @@ def test_extension(selenium):
             extensions = WebDriverWait(
                 selenium, timeout=10,
                 ignored_exceptions=StaleElementReferenceException).until(
-                    lambda s: s.find_element_by_id(
+                    lambda s: s.find_element(By.ID,
                         'extensions-tbody').text)
             assert 'Test Extension (empty)' in extensions
     """
@@ -136,15 +139,16 @@ def test_preferences_marker(testdir, httpserver):
     file_test = testdir.makepyfile(
         """
         import pytest
+        from selenium.webdriver.common.by import By
         @pytest.mark.nondestructive
         @pytest.mark.firefox_preferences({
             'browser.anchor_color': '#FF69B4',
             'browser.display.foreground_color': '#FF0000',
             'browser.display.use_document_colors': False})
         def test_preferences(base_url, selenium):
             selenium.get(base_url)
-            header = selenium.find_element_by_tag_name('h1')
-            anchor = selenium.find_element_by_tag_name('a')
+            header = selenium.find_element(By.TAG_NAME, 'h1')
+            anchor = selenium.find_element(By.TAG_NAME, 'a')
             header_color = header.value_of_css_property('color')
             anchor_color = anchor.value_of_css_property('color')
             assert header_color == 'rgb(255, 0, 0)'

testing/test_saucelabs.py

@@ -8,6 +8,8 @@
 
 import pytest
 
+from pytest_selenium.drivers.cloud import Provider
+
 pytestmark = [pytest.mark.skip_selenium, pytest.mark.nondestructive]
 
 
@@ -68,7 +70,6 @@ def test_missing_api_key_file(failure, monkeypatch, tmpdir):
     ],
 )
 def test_invalid_credentials_env(failure, monkeypatch, tmpdir, username, key):
-    monkeypatch.setattr(os.path, "expanduser", lambda p: str(tmpdir))
     monkeypatch.setenv(username, "foo")
     monkeypatch.setenv(key, "bar")
     out = failure()
@@ -77,8 +78,9 @@ def test_invalid_credentials_env(failure, monkeypatch, tmpdir, username, key):
 
 
 def test_invalid_credentials_file(failure, monkeypatch, tmpdir):
-    monkeypatch.setattr(os.path, "expanduser", lambda p: str(tmpdir))
-    tmpdir.join(".saucelabs").write("[credentials]\nusername=foo\nkey=bar")
+    cfg_file = tmpdir.join(".saucelabs")
+    cfg_file.write("[credentials]\nusername=foo\nkey=bar")
+    monkeypatch.setattr(Provider, "config_file_path", str(cfg_file))
     out = failure()
     messages = ["Sauce Labs Authentication Error", "basic auth failed", "Unauthorized"]
     assert any(message in out for message in messages)

testing/test_testingbot.py

@@ -7,6 +7,8 @@
 
 from functools import partial
 
+from pytest_selenium.drivers.cloud import Provider
+
 "'as TB' to avoid pytest trying to collect the class"
 from pytest_selenium.drivers.testingbot import HOST, PORT, TestingBot as TB
 
@@ -66,7 +68,6 @@ def test_missing_secret_file(failure, monkeypatch, tmpdir):
     [("TESTINGBOT_KEY", "TESTINGBOT_SECRET"), ("TESTINGBOT_PSW", "TESTINGBOT_USR")],
 )
 def test_invalid_credentials_env(failure, monkeypatch, tmpdir, key, secret):
-    monkeypatch.setattr(os.path, "expanduser", lambda p: str(tmpdir))
     monkeypatch.setenv(key, "foo")
     monkeypatch.setenv(secret, "bar")
     out = failure()
@@ -75,8 +76,9 @@ def test_invalid_credentials_env(failure, monkeypatch, tmpdir, key, secret):
 
 
 def test_invalid_credentials_file(failure, monkeypatch, tmpdir):
-    monkeypatch.setattr(os.path, "expanduser", lambda p: str(tmpdir))
-    tmpdir.join(".testingbot").write("[credentials]\nkey=foo\nsecret=bar")
+    cfg_file = tmpdir.join(".testingbot")
+    cfg_file.write("[credentials]\nkey=foo\nsecret=bar")
+    monkeypatch.setattr(Provider, "config_file_path", str(cfg_file))
     out = failure()
     messages = ["incorrect TestingBot credentials", "basic auth failed"]
     assert any(message in out for message in messages)