Fix line number reported when failing by Qt logging

Fix #55

Author: nicoddemus

pytestqt/_tests/test_logging.py

@@ -291,3 +291,27 @@ def test1():
     res = testdir.inline_run()
     passed = 1 if apply_mark else 0
     res.assertoutcome(passed=passed, failed=int(not passed))
+
+
+def test_logging_fails_lineno(testdir):
+    """
+    Test that tests when failing because log messages were emitted report
+    the correct line number.
+
+    :type testdir: _pytest.pytester.TmpTestdir
+    """
+    testdir.makeini(
+        """
+        [pytest]
+        qt_log_level_fail = WARNING
+        """
+    )
+    testdir.makepyfile(
+        """
+        from pytestqt.qt_compat import qWarning
+        def test_foo():
+            qWarning('this is a WARNING message')
+        """
+    )
+    res = testdir.runpytest()
+    res.stdout.fnmatch_lines('*test_logging_fails_lineno.py:2: Failure:*')

pytestqt/plugin.py

@@ -799,8 +799,9 @@ class _QtLogLevelErrorRepr(TerminalRepr):
 
     def __init__(self, item, level):
         msg = 'Failure: Qt messages with level {0} or above emitted'
-        path, line, _ = item.location
-        self.fileloc = ReprFileLocation(path, line, msg.format(level.upper()))
+        path, line_index, _ = item.location
+        self.fileloc = ReprFileLocation(path, lineno=line_index + 1,
+                                        message=msg.format(level.upper()))
         self.sections = []
 
     def addsection(self, name, content, sep="-"):