Added an extra test to cover the case where a href would be contained in the dictionary.

Dictionary string generation now uses json.dumps instead of the handmade json.dumps.

Author: ExaltedBagel

pytest_html/plugin.py

@@ -530,9 +530,8 @@ def _generate_environment(self, config):
             elif isinstance(value, (list, tuple, set)):
                 value = ", ".join(str(i) for i in sorted(map(str, value)))
             elif isinstance(value, dict):
-                key_value_list = [f"'{k}': {value[k]}" for k in sorted(value)]
-                value = ", ".join(key_value_list)
-                value = "{" + value + "}"
+                sorted_dict = {k: value[k] for k in sorted(value)}
+                value = json.dumps(sorted_dict)
             raw_value_string = raw(str(value))
             rows.append(html.tr(html.td(key), html.td(raw_value_string)))
 

testing/test_pytest_html.py

@@ -695,26 +695,44 @@ def pytest_configure(config):
         assert len(re.findall(expected_html_re, html)) == 1, html
 
     _unordered_dict = {k: len(k) for k in _unsorted_tuples[0]}
+    _unordered_dict_expected = (
+        r'<td>content</td>\n\s+<td>{"123Go": 5, "Hello": 5, '
+        r'"fzWZP6vKRv": 10, "garAge": 6, "hello": 5}</td>'
+    )
+    _unordered_dict_with_html = {
+        "First Link": r'<a href="https://www.w3schools.com">W3Schools</a>',
+        "Second Link": r'<a href="https://www.w3schools.com">W2Schools</a>',
+        "Third Link": r'<a href="https://www.w3schools.com">W4Schools</a>',
+    }
+    _unordered_dict_with_html_expected = (
+        r"<td>content</td>\n\s+<td>{"
+        r'"First Link": "<a href=\\"https://www.w3schools.com\\">W3Schools</a>", '
+        r'"Second Link": "<a href=\\"https://www.w3schools.com\\">W2Schools</a>", '
+        r'"Third Link": "<a href=\\"https://www.w3schools.com\\">W4Schools</a>"}</td>'
+    )
 
-    @pytest.mark.parametrize("unordered_dict", [_unordered_dict])
-    def test_environment_unordered_dict_value(self, testdir, unordered_dict):
-        expected_html_re = (
-            r"<td>content</td>\n\s+<td>{'123Go': 5, 'Hello': 5, "
-            r"'fzWZP6vKRv': 10, 'garAge': 6, 'hello': 5}</td>"
-        )
+    @pytest.mark.parametrize(
+        "unordered_dict,expected_output",
+        [
+            (_unordered_dict, _unordered_dict_expected),
+            (_unordered_dict_with_html, _unordered_dict_with_html_expected),
+        ],
+    )
+    def test_environment_unordered_dict_value(
+        self, testdir, unordered_dict, expected_output
+    ):
         testdir.makeconftest(
-            """
+            f"""
             def pytest_configure(config):
-                values = dict({'Hello': 5, 'fzWZP6vKRv': 10, 'garAge': 6, 'hello': 5,
-                               '123Go': 5})
+                values = dict({json.dumps(unordered_dict)})
                 config._metadata['content'] = values
         """
         )
         testdir.makepyfile("def test_pass(): pass")
         result, html = run(testdir)
         assert result.ret == 0
         assert "Environment" in html
-        assert len(re.findall(expected_html_re, html)) == 1, html
+        assert len(re.findall(expected_output, html)) == 1, html
 
     def test_environment_ordered(self, testdir):
         testdir.makeconftest(