Merge pull request #277 from christiansandberg/fix-missing-image

Fix image missing when using Base64 content

Author: BeyondEvil

pytest_html/plugin.py

@@ -319,7 +319,12 @@ def _make_media_html_div(
                 href = src = self.create_asset(
                     content, extra_index, test_index, extra.get("extension"), "wb"
                 )
-                html_div = html.a(class_=base_extra_class, target="_blank", href=href)
+                html_div = html.a(
+                    raw(base_extra_string.format(src)),
+                    class_=base_extra_class,
+                    target="_blank",
+                    href=href,
+                )
             return html_div
 
         def _append_image(self, extra, extra_index, test_index):

testing/test_pytest_html.py

@@ -502,7 +502,9 @@ def pytest_runtest_makereport(item, call):
         assert result.ret == 0
         src = f"assets/test_extra_image_separated.py__test_pass_0_0.{file_extension}"
         link = f'<a class="image" href="{src}" target="_blank">'
+        img = f'<img src="{src}"/>'
         assert link in html
+        assert img in html
         assert os.path.exists(src)
 
     @pytest.mark.parametrize(
@@ -536,8 +538,10 @@ def test_fail():
             asset_name = "test_extra_image_separated_rerun.py__test_fail"
             src = f"assets/{asset_name}_0_{i}.{file_extension}"
             link = f'<a class="image" href="{src}" target="_blank">'
+            img = f'<img src="{src}"/>'
             assert result.ret
             assert link in html
+            assert img in html
             assert os.path.exists(src)
 
     @pytest.mark.parametrize("src_type", ["https://", "file://", "image.png"])