Merge pull request #60 from edgarrmondragon/fix/third-party-exceptions

fix: Reference the correct line number in third-party exceptions

Author: utgwkk

plugin_test.py

@@ -69,6 +69,31 @@ def test_fail():
     )
 
 
+def test_annotation_third_party_exception(testdir):
+    testdir.makepyfile(
+        my_module="""
+        def fn():
+            raise Exception('oops')
+        """
+    )
+
+    testdir.makepyfile(
+        """
+        import pytest
+        from my_module import fn
+        pytest_plugins = 'pytest_github_actions_annotate_failures'
+
+        def test_fail():
+            fn()
+        """
+    )
+    testdir.monkeypatch.setenv("GITHUB_ACTIONS", "true")
+    result = testdir.runpytest_subprocess()
+    result.stderr.fnmatch_lines(
+        ["::error file=test_annotation_third_party_exception.py,line=6::test_fail*oops*",]
+    )
+
+
 def test_annotation_fail_disabled_outside_workflow(testdir):
     testdir.makepyfile(
         """

pytest_github_actions_annotate_failures/plugin.py

@@ -59,7 +59,12 @@ def pytest_runtest_makereport(item, call):
         # get the error message and line number from the actual error
         if hasattr(report.longrepr, "reprcrash"):
             longrepr += "\n\n" + report.longrepr.reprcrash.message
-            lineno = report.longrepr.reprcrash.lineno
+            traceback_entries = report.longrepr.reprtraceback.reprentries
+            if len(traceback_entries) > 1:
+                # Handle third-party exceptions
+                lineno = traceback_entries[0].reprfileloc.lineno
+            else:
+                lineno = report.longrepr.reprcrash.lineno
         elif isinstance(report.longrepr, tuple):
             _, lineno, message = report.longrepr
             longrepr += "\n\n" + message