Update pytests (#96)

* Update pytests

* Add .env3 to the gitignore

* Add pre-commit configuration

* Use `black` for linting

* Remove unused test dependencies

* Configure black

* Apply `black` formatting tool to the codebase

* Fix version discovery

* Delete test module that never run a test

Author: youtux

.gitignore

@@ -2,6 +2,7 @@
 *.rej
 *.py[cod]
 /.env
+/.env3
 *.orig
 
 # C extensions

.pre-commit-config.yaml

@@ -0,0 +1,14 @@
+# See https://pre-commit.com for more information
+# See https://pre-commit.com/hooks.html for more hooks
+repos:
+-   repo: https://github.com/psf/black
+    rev: 20.8b1
+    hooks:
+    - id: black
+-   repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v3.2.0
+    hooks:
+    -   id: trailing-whitespace
+    -   id: end-of-file-fixer
+    -   id: check-yaml
+    -   id: check-added-large-files

pyproject.toml

@@ -0,0 +1,3 @@
+[tool.black]
+line-length = 120
+target-version = ['py27', 'py35', 'py36', 'py37', 'py38']

pytest_factoryboy/__init__.py

@@ -1,7 +1,7 @@
 """pytest-factoryboy public API."""
 from .fixture import register, LazyFixture
 
-__version__ = '2.0.3'
+__version__ = "2.0.3"
 
 
 __all__ = [

pytest_factoryboy/fixture.py

@@ -144,7 +144,9 @@ def get_model_name(factory_class):
     """Get model fixture name by factory."""
     return (
         inflection.underscore(factory_class._meta.model.__name__)
-        if not isinstance(factory_class._meta.model, str) else factory_class._meta.model)
+        if not isinstance(factory_class._meta.model, str)
+        else factory_class._meta.model
+    )
 
 
 def get_factory_name(factory_class):
@@ -164,17 +166,15 @@ def is_dep(value):
         if isinstance(value, factory.RelatedFactory):
             return False
         if isinstance(value, factory.SubFactory) and get_model_name(value.get_factory()) == parent_model_name:
-                return False
+            return False
         if isinstance(value, factory.declarations.PostGeneration):
             # Dependency on extracted value
             return True
 
         return True
 
     return [
-        SEPARATOR.join((model_name, attr))
-        for attr, value in factory_class._meta.declarations.items()
-        if is_dep(value)
+        SEPARATOR.join((model_name, attr)) for attr, value in factory_class._meta.declarations.items() if is_dep(value)
     ]
 
 
@@ -199,7 +199,8 @@ class Factory(factory_class):
         pass
 
     Factory._meta.base_declarations = dict(
-        (k, v) for k, v in Factory._meta.base_declarations.items()
+        (k, v)
+        for k, v in Factory._meta.base_declarations.items()
         if not isinstance(v, factory.declarations.PostGenerationDeclaration)
     )
     Factory._meta.post_declarations = factory.builder.DeclarationSet()
@@ -233,7 +234,7 @@ class Factory(factory_class):
             argname = "".join((prefix, attr))
             extra = {}
             for k, v in factory_class._meta.post_declarations.contexts[attr].items():
-                if k == '':
+                if k == "":
                     continue
                 post_attr = SEPARATOR.join((argname, k))
 
@@ -339,10 +340,7 @@ def __init__(self, fixture):
         self.fixture = fixture
         if callable(self.fixture):
             params = signature(self.fixture).parameters.values()
-            self.args = [
-                param.name for param in params
-                if param.kind == param.POSITIONAL_OR_KEYWORD
-            ]
+            self.args = [param.name for param in params if param.kind == param.POSITIONAL_OR_KEYWORD]
         else:
             self.args = [self.fixture]
 

pytest_factoryboy/plugin.py

@@ -27,11 +27,11 @@ def defer(self, functions):
         self.deferred.append(functions)
 
     def get_deps(self, request, fixture, deps=None):
-        request = request.getfixturevalue('request')
+        request = request.getfixturevalue("request")
 
         if deps is None:
             deps = set([fixture])
-        if fixture == 'request':
+        if fixture == "request":
             return deps
 
         for fixturedef in request._fixturemanager.getfixturedefs(fixture, request._pyfuncitem.parent.nodeid) or []:
@@ -43,7 +43,7 @@ def get_deps(self, request, fixture, deps=None):
 
     def get_current_deps(self, request):
         deps = set()
-        while hasattr(request, '_parent_request'):
+        while hasattr(request, "_parent_request"):
             if request.fixturename and request.fixturename not in getattr(request, "_fixturedefs", {}):
                 deps.add(request.fixturename)
             request = request._parent_request
@@ -113,6 +113,7 @@ def pytest_runtest_call(item):
 def pytest_addhooks(pluginmanager):
     """Register plugin hooks."""
     from pytest_factoryboy import hooks
+
     pluginmanager.add_hookspecs(hooks)
 
 

requirements-testing.txt

@@ -1,4 +0,0 @@
-mock
-pytest-pep8
-pytest-cov
-pytest-cache

setup.py

@@ -9,13 +9,15 @@
 dirname = os.path.dirname(__file__)
 
 long_description = (
-    codecs.open(os.path.join(dirname, "README.rst"), encoding="utf-8").read() + "\n" +
-    codecs.open(os.path.join(dirname, "AUTHORS.rst"), encoding="utf-8").read() + "\n" +
-    codecs.open(os.path.join(dirname, "CHANGES.rst"), encoding="utf-8").read()
+    codecs.open(os.path.join(dirname, "README.rst"), encoding="utf-8").read()
+    + "\n"
+    + codecs.open(os.path.join(dirname, "AUTHORS.rst"), encoding="utf-8").read()
+    + "\n"
+    + codecs.open(os.path.join(dirname, "CHANGES.rst"), encoding="utf-8").read()
 )
 
-with codecs.open(os.path.join(dirname, 'pytest_factoryboy', '__init__.py'), encoding='utf-8') as fd:
-    VERSION = re.compile(r".*__version__ = '(.*?)'", re.S).match(fd.read()).group(1)
+with codecs.open(os.path.join(dirname, "pytest_factoryboy", "__init__.py"), encoding="utf-8") as fd:
+    VERSION = re.compile(r'.*__version__ = "(.*?)"', re.S).match(fd.read()).group(1)
 
 setup(
     name="pytest-factoryboy",

tests/test_attributes_field.py

@@ -28,17 +28,15 @@ def __init__(self, name):
 
 
 class AuthorFactory(factory.Factory):
-
     class Meta:
         model = Author
 
     name = "Charles Dickens"
 
-    book = factory.RelatedFactory('tests.test_circular.BookFactory', 'author')
+    book = factory.RelatedFactory("tests.test_circular.BookFactory", "author")
 
 
 class BookFactory(factory.Factory):
-
     class Meta:
         model = Book