Skip to content

Commit 8403803

Browse files
committed
Install the whole package, including pytest, otherwise we can't run type-checks
1 parent 837efc4 commit 8403803

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

.github/workflows/main.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,23 +40,23 @@ jobs:
4040
ignore-test-outcome: false
4141
- python-version: "3.10"
4242
toxfactor: py3.10
43-
ignore-typecheck-outcome: true
43+
ignore-typecheck-outcome: false
4444
ignore-test-outcome: false
4545
- python-version: "3.11"
4646
toxfactor: py3.11
47-
ignore-typecheck-outcome: true
47+
ignore-typecheck-outcome: false
4848
ignore-test-outcome: false
4949
- python-version: "3.12"
5050
toxfactor: py3.12
51-
ignore-typecheck-outcome: true
51+
ignore-typecheck-outcome: false
5252
ignore-test-outcome: false
5353
- python-version: "3.13"
5454
toxfactor: py3.13
5555
ignore-typecheck-outcome: false
5656
ignore-test-outcome: false
5757
- python-version: "3.14"
5858
toxfactor: py3.14
59-
ignore-typecheck-outcome: true # TODO: Set to true once python3.14 is stable
59+
ignore-typecheck-outcome: false
6060
ignore-test-outcome: false
6161
steps:
6262
- uses: actions/checkout@v4
@@ -71,7 +71,7 @@ jobs:
7171
python -m pip install poetry==2.0.0
7272
- name: Configure poetry
7373
run: |
74-
python -m poetry config virtualenvs.in-project true
74+
poetry config virtualenvs.in-project true
7575
- name: Cache the virtualenv
7676
id: poetry-dependencies-cache
7777
uses: actions/cache@v3
@@ -81,7 +81,7 @@ jobs:
8181
- name: Install dev dependencies
8282
if: steps.poetry-dependencies-cache.outputs.cache-hit != 'true'
8383
run: |
84-
python -m poetry install --only=dev
84+
poetry install
8585
- name: Download artifact
8686
uses: actions/download-artifact@v4
8787
with:
@@ -91,8 +91,7 @@ jobs:
9191
# Ignore errors for older pythons
9292
continue-on-error: ${{ matrix.ignore-typecheck-outcome }}
9393
run: |
94-
source .venv/bin/activate
95-
mypy pytest_factoryboy
94+
poetry run mypy pytest_factoryboy
9695
- name: Test with tox
9796
continue-on-error: ${{ matrix.ignore-test-outcome }}
9897
run: |

0 commit comments

Comments
 (0)