Merge pull request #249 from pytest-dev/fix-2.8

Fix version 2.8.0 being incompatible with combo of python < 3.12 and factoryboy < 3.3

Author: youtux

CHANGES.rst

@@ -27,6 +27,31 @@ Fixed
 Security
 ++++++++
 
+2.8.1
+----------
+
+Added
++++++
+* Test against all supported ``factory-boy`` versions
+
+Changed
++++++++
+
+Deprecated
+++++++++++
+
+Removed
++++++++
+
+Fixed
++++++
+* Fix incompatibility when using the combination of python < 3.12 and factory-boy < 3.3.
+
+  * The error was: ``TypeError: type 'Factory' is not subscriptable``
+
+Security
+++++++++
+
 2.8.0
 ----------
 

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pytest-factoryboy"
-version = "2.8.0"
+version = "2.8.1"
 description = "Factory Boy support for pytest."
 authors = [ { name = "Oleg Pidsadnyi", email= "oleg.pidsadnyi@gmail.com" } ]
 maintainers = [ { name = "Alessio Bogon", email = "778703+youtux@users.noreply.github.com" } ]

src/pytest_factoryboy/fixture.py

@@ -368,11 +368,14 @@ def model_fixture(request: SubRequest, factory_name: str) -> object:
 
     factory_class: type[Factory[object]] = request.getfixturevalue(factory_name)
 
-    # Create model fixture instance
-    NewFactory: type[Factory[object]] = cast(type[Factory[object]], type("Factory", (factory_class,), {}))
+    # create Factory override for the model fixture
+    NewFactory: type[Factory[object]] = type("Factory", (factory_class,), {})
     # equivalent to:
     # class Factory(factory_class):
     #     pass
+    # NewFactory = Factory
+    # del Factory
+
     # it just makes mypy understand it.
 
     NewFactory._meta.base_declarations = {

tox.ini

@@ -2,6 +2,7 @@
 distshare = {homedir}/.tox/distshare
 envlist = py{3.9,3.10,3.11,3.12,3.13,3.14}-pytest{7.3,7.4,8.0,8.1,8.2,8.3,8.4,latest,main}
           py{3.9,3.10,3.11}-pytest{7.0,7.1,7.2}
+          py{3.9,3.10,3.11,3.12,3.13,3.14}-factoryboy{2.10,2.11,2.12,3.0,3.1,3.2,3.3,latest,main}
 
 [testenv]
 parallel_show_output = true
@@ -22,6 +23,16 @@ deps =
     pytest7.1: pytest~=7.1.0
     pytest7.0: pytest~=7.0.0
 
+    factoryboylatest: factory-boy
+    factoryboymain: git+https://github.com/FactoryBoy/factory_boy.git@master
+    factoryboy3.3: factory-boy~=3.3.0
+    factoryboy3.2: factory-boy~=3.2.0
+    factoryboy3.1: factory-boy~=3.1.0
+    factoryboy3.0: factory-boy~=3.0.0
+    factoryboy2.12: factory-boy~=2.12.0
+    factoryboy2.11: factory-boy~=2.11.0
+    factoryboy2.10: factory-boy~=2.10.0
+
     coverage[toml]
 
 [pytest]