should try to tear down db even if keeping it and db names need to be unique

Author: SalmonMode

pytest_django/fixtures.py

@@ -104,7 +104,7 @@ def django_db_setup(
     if not django_db_use_migrations:
         _disable_native_migrations()
 
-    if django_db_keepdb:
+    if django_db_keepdb and not django_db_createdb:
         setup_databases_args["keepdb"] = True
 
     with _django_db_blocker.unblock():

pytest_django_test/settings_base.py

@@ -1,3 +1,5 @@
+import os
+
 import django
 
 ROOT_URLCONF = "pytest_django_test.urls"
@@ -12,6 +14,10 @@
 STATIC_URL = "/static/"
 SECRET_KEY = "foobar"
 
+# Used to construct unique test database names to allow detox to run multiple
+# versions at the same time
+db_suffix = "_%s" % os.getuid()
+
 MIDDLEWARE = [
     "django.contrib.sessions.middleware.SessionMiddleware",
     "django.middleware.common.CommonMiddleware",

pytest_django_test/settings_mysql_innodb.py

@@ -3,7 +3,7 @@
 DATABASES = {
     "default": {
         "ENGINE": "django.db.backends.mysql",
-        "NAME": "pytest_django_should_never_get_accessed",
+        "NAME": "pytest_django_should_never_get_accessed" + db_suffix,
         "HOST": "localhost",
         "USER": "root",
         "OPTIONS": {"init_command": "SET default_storage_engine=InnoDB"},

pytest_django_test/settings_mysql_myisam.py

@@ -3,7 +3,7 @@
 DATABASES = {
     "default": {
         "ENGINE": "django.db.backends.mysql",
-        "NAME": "pytest_django_should_never_get_accessed",
+        "NAME": "pytest_django_should_never_get_accessed" + db_suffix,
         "HOST": "localhost",
         "USER": "root",
         "OPTIONS": {"init_command": "SET default_storage_engine=MyISAM"},

pytest_django_test/settings_postgres.py

@@ -12,7 +12,7 @@
 DATABASES = {
     "default": {
         "ENGINE": "django.db.backends.postgresql_psycopg2",
-        "NAME": "pytest_django_should_never_get_accessed",
+        "NAME": "pytest_django_should_never_get_accessed" + db_suffix,
         "HOST": "localhost",
         "USER": "",
     }

pytest_django_test/settings_sqlite.py

@@ -3,6 +3,6 @@
 DATABASES = {
     "default": {
         "ENGINE": "django.db.backends.sqlite3",
-        "NAME": "/should_not_be_accessed",
+        "NAME": "/should_not_be_accessed" + db_suffix,
     }
 }

pytest_django_test/settings_sqlite_file.py

@@ -11,7 +11,7 @@
 DATABASES = {
     "default": {
         "ENGINE": "django.db.backends.sqlite3",
-        "NAME": "/pytest_django_should_never_get_accessed",
+        "NAME": "/pytest_django_should_never_get_accessed" + db_suffix,
         "TEST": {"NAME": _filename},
     }
 }