[fix] Fixes a bug that caused an INTERNALERROR when an __init__.py raised an error.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>

Author: seifertm

pytest_asyncio/plugin.py

@@ -620,6 +620,24 @@ def _patched_collect():
             collector.obj.__pytest_asyncio_scoped_event_loop = scoped_event_loop
             return collector.__original_collect()
 
+        collector.__original_collect = collector.collect
+        collector.collect = _patched_collect
+    elif type(collector) is Package:
+
+        def _patched_collect():
+            # When collector is a package, collector.obj is the package's __init__.py.
+            # pytest doesn't seem to collect fixtures in __init__.py.
+            # Using parsefactories to collect fixtures in __init__.py their baseid will
+            # end with "__init__.py", thus limiting the scope of the fixture to the
+            # init module. Therefore, we tell the pluginmanager explicitly to collect
+            # the fixtures in the init module, but strip "__init__.py" from the baseid
+            # Possibly related to https://github.com/pytest-dev/pytest/issues/4085
+            collector.obj.__pytest_asyncio_scoped_event_loop = scoped_event_loop
+            fixturemanager = collector.config.pluginmanager.get_plugin("funcmanage")
+            package_node_id = _removesuffix(collector.nodeid, "__init__.py")
+            fixturemanager.parsefactories(collector.obj, nodeid=package_node_id)
+            return collector.__original_collect()
+
         collector.__original_collect = collector.collect
         collector.collect = _patched_collect
     else:
@@ -628,17 +646,6 @@ def _patched_collect():
         if pyobject is None:
             return
         pyobject.__pytest_asyncio_scoped_event_loop = scoped_event_loop
-    # When collector is a package, collector.obj is the package's __init__.py.
-    # pytest doesn't seem to collect fixtures in __init__.py.
-    # Using parsefactories to collect fixtures in __init__.py their baseid will end
-    # with "__init__.py", thus limiting the scope of the fixture to the init module.
-    # Therefore, we tell the pluginmanager explicitly to collect the fixtures
-    # in the init module, but strip "__init__.py" from the baseid
-    # Possibly related to https://github.com/pytest-dev/pytest/issues/4085
-    if isinstance(collector, Package):
-        fixturemanager = collector.config.pluginmanager.get_plugin("funcmanage")
-        package_node_id = _removesuffix(collector.nodeid, "__init__.py")
-        fixturemanager.parsefactories(collector.obj, nodeid=package_node_id)
 
 
 def _removesuffix(s: str, suffix: str) -> str:

tests/test_import.py

@@ -3,7 +3,7 @@
 from pytest import Pytester
 
 
-def test_import_warning(pytester: Pytester):
+def test_import_warning_does_not_cause_internal_error(pytester: Pytester):
     pytester.makepyfile(
         dedent(
             """\
@@ -16,3 +16,21 @@ async def test_errors_out():
     )
     result = pytester.runpytest("--asyncio-mode=auto")
     result.assert_outcomes(errors=1)
+
+
+def test_import_warning_in_package_does_not_cause_internal_error(pytester: Pytester):
+    pytester.makepyfile(
+        __init__=dedent(
+            """\
+                raise ImportWarning()
+            """
+        ),
+        test_a=dedent(
+            """\
+                async def test_errors_out():
+                    pass
+            """
+        ),
+    )
+    result = pytester.runpytest("--asyncio-mode=auto")
+    result.assert_outcomes(errors=1)