refactor: Removed warning when requesting a fixture named *event_loop*.

Author: seifertm

pytest_asyncio/plugin.py

@@ -70,10 +70,6 @@ class PytestAsyncioError(Exception):
     """Base class for exceptions raised by pytest-asyncio"""
 
 
-class MultipleEventLoopsRequestedError(PytestAsyncioError):
-    """Raised when a test requests multiple asyncio event loops."""
-
-
 class Mode(str, enum.Enum):
     AUTO = "auto"
     STRICT = "strict"
@@ -808,14 +804,6 @@ def pytest_generate_tests(metafunc: Metafunc) -> None:
             return
         fixturemanager = metafunc.config.pluginmanager.get_plugin("funcmanage")
         assert fixturemanager is not None
-        if "event_loop" in metafunc.fixturenames:
-            raise MultipleEventLoopsRequestedError(
-                _MULTIPLE_LOOPS_REQUESTED_ERROR.format(
-                    test_name=metafunc.definition.nodeid,
-                    scope=scope,
-                    scoped_loop_node=event_loop_node.nodeid,
-                ),
-            )
         # Add the scoped event loop fixture to Metafunc's list of fixture names and
         # fixturedefs and leave the actual parametrization to pytest
         # The fixture needs to be appended to avoid messing up the fixture evaluation
@@ -943,18 +931,6 @@ def inner(*args, **kwargs):
     return inner
 
 
-_MULTIPLE_LOOPS_REQUESTED_ERROR = dedent(
-    """\
-        Multiple asyncio event loops with different scopes have been requested
-        by {test_name}. The test explicitly requests the event_loop fixture, while
-        another event loop with {scope} scope is provided by {scoped_loop_node}.
-        Remove "event_loop" from the requested fixture in your test to run the test
-        in a {scope}-scoped event loop or remove the scope argument from the "asyncio"
-        mark to run the test in a function-scoped event loop.
-    """
-)
-
-
 def pytest_runtest_setup(item: pytest.Item) -> None:
     marker = item.get_closest_marker("asyncio")
     if marker is None:

tests/markers/test_module_scope.py

@@ -36,28 +36,6 @@ async def test_this_runs_in_same_loop(self):
     result.assert_outcomes(passed=3)
 
 
-def test_raise_when_event_loop_fixture_is_requested_in_addition_to_scoped_loop(
-    pytester: Pytester,
-):
-    pytester.makeini("[pytest]\nasyncio_default_fixture_loop_scope = function")
-    pytester.makepyfile(
-        dedent(
-            """\
-            import asyncio
-            import pytest
-
-            pytestmark = pytest.mark.asyncio(loop_scope="module")
-
-            async def test_remember_loop(event_loop):
-                pass
-            """
-        )
-    )
-    result = pytester.runpytest("--asyncio-mode=strict")
-    result.assert_outcomes(errors=1)
-    result.stdout.fnmatch_lines("*MultipleEventLoopsRequestedError: *")
-
-
 def test_asyncio_mark_respects_the_loop_policy(
     pytester: Pytester,
 ):

tests/markers/test_package_scope.py

@@ -69,28 +69,6 @@ async def test_subpackage_runs_in_different_loop():
     result.assert_outcomes(passed=4)
 
 
-def test_raise_when_event_loop_fixture_is_requested_in_addition_to_scoped_loop(
-    pytester: Pytester,
-):
-    pytester.makeini("[pytest]\nasyncio_default_fixture_loop_scope = function")
-    pytester.makepyfile(
-        __init__="",
-        test_raises=dedent(
-            """\
-            import asyncio
-            import pytest
-
-            @pytest.mark.asyncio(loop_scope="package")
-            async def test_remember_loop(event_loop):
-                pass
-            """
-        ),
-    )
-    result = pytester.runpytest("--asyncio-mode=strict")
-    result.assert_outcomes(errors=1)
-    result.stdout.fnmatch_lines("*MultipleEventLoopsRequestedError: *")
-
-
 def test_asyncio_mark_respects_the_loop_policy(
     pytester: Pytester,
 ):

tests/markers/test_session_scope.py

@@ -70,28 +70,6 @@ async def test_subpackage_runs_in_same_loop():
     result.assert_outcomes(passed=4)
 
 
-def test_raise_when_event_loop_fixture_is_requested_in_addition_to_scoped_loop(
-    pytester: Pytester,
-):
-    pytester.makeini("[pytest]\nasyncio_default_fixture_loop_scope = function")
-    pytester.makepyfile(
-        __init__="",
-        test_raises=dedent(
-            """\
-            import asyncio
-            import pytest
-
-            @pytest.mark.asyncio(loop_scope="session")
-            async def test_remember_loop(event_loop):
-                pass
-            """
-        ),
-    )
-    result = pytester.runpytest("--asyncio-mode=strict")
-    result.assert_outcomes(errors=1)
-    result.stdout.fnmatch_lines("*MultipleEventLoopsRequestedError: *")
-
-
 def test_asyncio_mark_respects_the_loop_policy(
     pytester: Pytester,
 ):