pre-commit and typing fixes

Author: RonnyPfannschmidt

.readthedocs.yaml

@@ -11,4 +11,4 @@ sphinx:
 python:
   install:
     - method: pip
-      path: .
+      path: .

testing/test_pluginmanager.py

@@ -1,8 +1,9 @@
 """
 ``PluginManager`` unit and public API testing.
 """
+from __future__ import annotations
 import pytest
-from typing import Any, List
+from typing import Any, Callable
 
 from pluggy import (
     HookCallError,
@@ -265,13 +266,12 @@ def test_with_result_memorized(pm: PluginManager, result_callback: bool) -> None
     correctly applies the ``result_callback`` function, when provided,
     to the result from calling each newly registered hook.
     """
-    out = []
+    out: list[int] = []
+    callback: Callable[[int], None] | None
     if not result_callback:
         callback = None
     else:
-
-        def callback(res) -> None:
-            out.append(res)
+        callback = out.append
 
     class Hooks:
         @hookspec(historic=True)
@@ -381,7 +381,7 @@ def he_method1(self, arg):
     class Plugin1:
         @hookimpl
         def he_method1(self, arg):
-            0 / 0
+            return 0 / 0
 
     pm.register(Plugin1())
     with pytest.raises(HookCallError):
@@ -570,7 +570,7 @@ def my_distributions():
 
 
 def test_add_tracefuncs(he_pm: PluginManager) -> None:
-    out: List[Any] = []
+    out: list[Any] = []
 
     class api1:
         @hookimpl
@@ -623,7 +623,7 @@ def he_method1(self):
             raise ValueError()
 
     he_pm.register(api1())
-    out: List[Any] = []
+    out: list[Any] = []
     he_pm.trace.root.setwriter(out.append)
     undo = he_pm.enable_tracing()
     try: