Add a few notes about usage expectations

Author: ArtyomVancyan

README.md

@@ -21,6 +21,8 @@ uvicorn main:app --reload
 
 - Integrate with any existing FastAPI project (no dependencies of the project should stop the work of
   the `fastapi-oauth2`)
+    * Implementation must allow to provide a context for configurations (also, see how it is done in another projects)
 - Use multiple OAuth2 providers at the same time
-- Token to user data, user data to token easy conversion
+    * There need to be provided a way to configure the OAuth2 for multiple providers
+- Token -> user data, user data -> token easy conversion
 - Customize OAuth2 routes

main.py

@@ -3,10 +3,12 @@
 from fastapi import FastAPI, Request, APIRouter
 from fastapi.responses import HTMLResponse
 from fastapi.templating import Jinja2Templates
+from social_core.backends.github import GithubOAuth2
 
 from demo.router import router as demo_router
 from fastapi_oauth2.middleware import OAuth2Middleware
 from fastapi_oauth2.router import router as oauth2_router
+from fastapi_oauth2.types import OAuth2Client
 
 router = APIRouter()
 templates = Jinja2Templates(directory="templates")
@@ -23,11 +25,12 @@ async def root(request: Request):
 app.include_router(oauth2_router)
 app.add_middleware(OAuth2Middleware, config={
     "allow_http": True,
-    "providers": {
-        "github": {
-            "client_id": "eccd08d6736b7999a32a",
-            "client_secret": "642999c1c5f2b3df8b877afdc78252ef5b594d31",
-            "redirect_uri": "http://127.0.0.1:8000/",
-        },
-    }
+    "clients": [
+        OAuth2Client(
+            backend=GithubOAuth2,
+            client_id="eccd08d6736b7999a32a",
+            client_secret="642999c1c5f2b3df8b877afdc78252ef5b594d31",
+            redirect_uri="http://127.0.0.1:8000/",
+        ),
+    ]
 })

src/fastapi_oauth2/middleware.py

@@ -6,8 +6,7 @@
 from starlette.requests import Request
 from starlette.types import Send, Receive, Scope, ASGIApp
 
-from .types import Config
-from .types import ConfigParams
+from .types import OAuth2Config
 from .utils import jwt_decode
 
 
@@ -25,11 +24,11 @@ async def authenticate(self, request: Request) -> Optional[Tuple["AuthCredential
 
 
 class OAuth2Middleware:
-    def __init__(self, app: ASGIApp, config: Union[Config, ConfigParams]) -> None:
-        if isinstance(config, Config):
+    def __init__(self, app: ASGIApp, config: Union[OAuth2Config, dict]) -> None:
+        if isinstance(config, OAuth2Config):
             self.config = config
         elif isinstance(config, dict):
-            self.config = Config(**config)
+            self.config = OAuth2Config(**config)
         else:
             raise ValueError("config does not contain valid parameters")
         self.auth_middleware = AuthenticationMiddleware(app, OAuth2Backend())

src/fastapi_oauth2/types.py

@@ -1,32 +1,46 @@
-from enum import Enum
-from typing import Dict, TypedDict
+from typing import List, Optional, Type
 
+from social_core.backends.oauth import BaseOAuth2
 
-class OAuth2Provider(str, Enum):
-    github = "github"
 
-
-class OAuth2Client(Dict[str, str]):
+class OAuth2Client:
+    backend: Type[BaseOAuth2]
     client_id: str
     client_secret: str
-    redirect_uri: str
-
-
-class ConfigParams(TypedDict):
+    redirect_uri: Optional[str]
+
+    def __init__(
+            self,
+            *,
+            backend: Type[BaseOAuth2],
+            client_id: str,
+            client_secret: str,
+            redirect_uri: Optional[str] = None,
+    ):
+        self.backend = backend
+        self.client_id = client_id
+        self.client_secret = client_secret
+        self.redirect_uri = redirect_uri
+
+
+class OAuth2Config:
     allow_http: bool
     jwt_secret: str
     jwt_expires: int
     jwt_algorithm: str
-    providers: Dict[OAuth2Provider, OAuth2Client]
-
-
-class Config:
-    allow_http: bool = False
-    jwt_secret: str = ""
-    jwt_expires: int = 900
-    jwt_algorithm: str = "HS256"
-    providers: Dict[OAuth2Provider, OAuth2Client] = {}
-
-    def __init__(self, **kwargs):
-        for key, value in kwargs.items():
-            setattr(self, key, value)
+    clients: List[OAuth2Client]
+
+    def __init__(
+            self,
+            *,
+            allow_http: bool = False,
+            jwt_secret: str = "",
+            jwt_expires: int = 900,
+            jwt_algorithm: str = "HS256",
+            clients: List[OAuth2Client] = None,
+    ):
+        self.allow_http = allow_http
+        self.jwt_secret = jwt_secret
+        self.jwt_expires = jwt_expires
+        self.jwt_algorithm = jwt_algorithm
+        self.clients = clients or []