Skip to content

Commit 9653855

Browse files
authored
Correctly set metrics tags for unknown issuer (#18926)
1 parent d029959 commit 9653855

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

tests/unit/oidc/test_views.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,12 @@ def body(self):
246246
assert isinstance(err, dict)
247247
assert err["code"] == "invalid-payload"
248248
assert err["description"] == "unknown trusted publishing issuer"
249+
assert metrics.increment.calls == [
250+
pretend.call(
251+
"warehouse.oidc.mint_token_from_oidc.unknown_issuer",
252+
tags=["issuer_url:nonexistent-issuer"],
253+
)
254+
]
249255

250256

251257
@pytest.mark.parametrize(

warehouse/oidc/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def mint_token_from_oidc(request: Request):
147147
if not service_name:
148148
request.metrics.increment(
149149
"warehouse.oidc.mint_token_from_oidc.unknown_issuer",
150-
tags={"issuer_url": unverified_issuer},
150+
tags=[f"issuer_url:{unverified_issuer}"],
151151
)
152152
return _invalid(
153153
errors=[

0 commit comments

Comments
 (0)