Skip to content

Commit 4d45513

Browse files
authored
chore: remove unused mapping (#18896)
The usage of `OIDC_ISSUER_URLS` was replaced in #15148 and is no longer needed. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
1 parent 2dfc2f9 commit 4d45513

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

tests/unit/oidc/test_utils.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -303,17 +303,6 @@ def test_oidc_context_principals():
303303

304304

305305
def test_oidc_maps_consistent():
306-
# Our various mappings should have equivalent cardinalities.
307-
assert len(utils.OIDC_ISSUER_URLS) == len(utils.OIDC_ISSUER_SERVICE_NAMES)
308-
assert len(utils.OIDC_ISSUER_URLS) == len(utils.OIDC_ISSUER_ADMIN_FLAGS)
309-
assert len(utils.OIDC_ISSUER_URLS) == len(utils.OIDC_PUBLISHER_CLASSES)
310-
311-
for iss in utils.OIDC_ISSUER_URLS:
312-
# Each issuer should be present in each mapping.
313-
assert iss in utils.OIDC_ISSUER_SERVICE_NAMES
314-
assert iss in utils.OIDC_ISSUER_ADMIN_FLAGS
315-
assert iss in utils.OIDC_PUBLISHER_CLASSES
316-
317306
for class_map in utils.OIDC_PUBLISHER_CLASSES.values():
318307
# The class mapping for pending and non-pending publisher models
319308
# should be distinct.

warehouse/oidc/utils.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,6 @@
4646
ACTIVESTATE_OIDC_ISSUER_URL: AdminFlagValue.DISALLOW_ACTIVESTATE_OIDC,
4747
}
4848

49-
OIDC_ISSUER_URLS = {
50-
GITHUB_OIDC_ISSUER_URL,
51-
GITLAB_OIDC_ISSUER_URL,
52-
GOOGLE_OIDC_ISSUER_URL,
53-
ACTIVESTATE_OIDC_ISSUER_URL,
54-
}
55-
5649
OIDC_PUBLISHER_CLASSES: dict[
5750
str, dict[bool, type[OIDCPublisher | PendingOIDCPublisher]]
5851
] = {

0 commit comments

Comments
 (0)