feat: add warehouse.task.start metric (#18439)

Author: JacobCoffee

tests/unit/test_tasks.py

@@ -243,7 +243,8 @@ def run(arg_, *, kwarg_=None):
             pretend.call("warehouse.task.run", tags=["task:warehouse.test.task"])
         ]
         assert metrics.increment.calls == [
-            pretend.call("warehouse.task.complete", tags=["task:warehouse.test.task"])
+            pretend.call("warehouse.task.start", tags=["task:warehouse.test.task"]),
+            pretend.call("warehouse.task.complete", tags=["task:warehouse.test.task"]),
         ]
 
     def test_run_retries_failed_transaction(self, metrics):
@@ -288,7 +289,8 @@ def run():
             pretend.call("warehouse.task.run", tags=["task:warehouse.test.task"])
         ]
         assert metrics.increment.calls == [
-            pretend.call("warehouse.task.retried", tags=["task:warehouse.test.task"])
+            pretend.call("warehouse.task.start", tags=["task:warehouse.test.task"]),
+            pretend.call("warehouse.task.retried", tags=["task:warehouse.test.task"]),
         ]
 
     def test_run_doesnt_retries_failed_transaction(self, metrics):
@@ -326,7 +328,8 @@ def run():
             pretend.call("warehouse.task.run", tags=["task:warehouse.test.task"])
         ]
         assert metrics.increment.calls == [
-            pretend.call("warehouse.task.failed", tags=["task:warehouse.test.task"])
+            pretend.call("warehouse.task.start", tags=["task:warehouse.test.task"]),
+            pretend.call("warehouse.task.failed", tags=["task:warehouse.test.task"]),
         ]
 
     def test_after_return_without_pyramid_env(self):

warehouse/tasks.py

@@ -72,6 +72,7 @@ def run(*args, **kwargs):
             metric_tags = [f"task:{obj.name}"]
 
             with request.tm, metrics.timed("warehouse.task.run", tags=metric_tags):
+                metrics.increment("warehouse.task.start", tags=metric_tags)
                 try:
                     result = original_run(*args, **kwargs)
                     metrics.increment("warehouse.task.complete", tags=metric_tags)