Adequate to newly introduced Ruff checks (#5042)

Author: abravalheri

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.9.9
+  rev: v0.12.0
   hooks:
   - id: ruff
     args: [--fix, --unsafe-fixes]

ruff.toml

@@ -73,6 +73,7 @@ ignore = [
 # Suppress nuisance warnings about module-import-not-at-top-of-file (E402) due to workaround for #4476
 "setuptools/__init__.py" = ["E402"]
 "pkg_resources/__init__.py" = ["E402", "ANN204"]
+"pkg_resources/tests/test_resources.py" = ["PT031"]
 
 [lint.isort]
 combine-as-imports = true

setuptools/tests/config/test_pyprojecttoml_dynamic_deps.py

@@ -103,7 +103,9 @@ def test_mixed_extras_require_optional_dependencies(tmp_path):
     path.build(files, prefix=tmp_path)
     pyproject = tmp_path / "pyproject.toml"
 
+    dist = Distribution({"extras_require": {"hello": ["world"]}})
+
     with pytest.warns(SetuptoolsWarning, match=".extras_require. overwritten"):
-        dist = Distribution({"extras_require": {"hello": ["world"]}})
         dist = apply_configuration(dist, pyproject)
-        assert dist.extras_require == {"docs": ["sphinx"]}
+
+    assert dist.extras_require == {"docs": ["sphinx"]}

setuptools/tests/test_build_py.py

@@ -165,7 +165,7 @@ def test_excluded_subpackages(tmpdir_cwd):
     build_py = dist.get_command_obj("build_py")
 
     msg = r"Python recognizes 'mypkg\.tests' as an importable package"
-    with pytest.warns(SetuptoolsDeprecationWarning, match=msg):
+    with pytest.warns(SetuptoolsDeprecationWarning, match=msg):  # noqa: PT031
         # TODO: To fix #3260 we need some transition period to deprecate the
         # existing behavior of `include_package_data`. After the transition, we
         # should remove the warning and fix the behavior.