Fix test monkeypatching and get_version() positional argument

- Updated assert_root() to patch vcs_versioning._get_version_impl instead of setuptools_scm
- Added root parameter to get_version() to support positional arguments (issue #669)
- Support PathLike in get_version() root parameter for type compatibility
- Updated test_basic_api.py to patch at the correct module level

Test improvements:
- test_root_parameter_pass_by now passes (was failing due to monkeypatch)
- 3/21 tests passing in test_basic_api
- test_parentdir_prefix now failing on output format (unrelated to refactoring)

Author: RonnyPfannschmidt

src/setuptools_scm/_get_version_impl.py

@@ -2,6 +2,8 @@
 
 from __future__ import annotations
 
+from os import PathLike
+
 from vcs_versioning._get_version_impl import _find_scm_in_parents
 from vcs_versioning._get_version_impl import _get_version
 from vcs_versioning._get_version_impl import _version_missing
@@ -12,13 +14,19 @@
 
 
 # Legacy get_version function (soft deprecated)
-def get_version(**kwargs: object) -> str:
+def get_version(root: str | PathLike[str] | None = None, **kwargs: object) -> str:
     """Legacy API - get version string
 
     This function is soft deprecated. Use Configuration.from_file() and _get_version() instead.
+
+    Args:
+        root: Optional root directory (can be passed as positional arg for backward compat)
+        **kwargs: Additional configuration parameters
     """
     from vcs_versioning.config import Configuration
 
+    if root is not None:
+        kwargs["root"] = root
     config = Configuration(**kwargs)  # type: ignore[arg-type]
     version = _get_version(config, force_write_version_files=False)
     if version is None:

testing/test_basic_api.py

@@ -61,7 +61,10 @@ def assertion(config: Configuration) -> ScmVersion:
 
         return ScmVersion(Version("1.0"), config=config)
 
-    monkeypatch.setattr(setuptools_scm._get_version_impl, "parse_version", assertion)
+    # Patch at vcs_versioning level since that's where the implementation lives
+    import vcs_versioning._get_version_impl
+
+    monkeypatch.setattr(vcs_versioning._get_version_impl, "parse_version", assertion)
 
 
 def test_root_parameter_creation(monkeypatch: pytest.MonkeyPatch) -> None: