Fix logging configuration, empty tag regex warning, and test patches

- Fixed parse_tag_regex handling to emit deprecation warning properly
- setuptools_scm.get_version now delegates to vcs_versioning.get_version
- Fixed import of strip_path_suffix in file_finders/git.py to use vcs_versioning
- Fixed test patches in test_git.py to patch _git module instead of re-exported git

Author: RonnyPfannschmidt

nextgen/vcs-versioning/src/vcs_versioning/_get_version_impl.py

@@ -248,9 +248,14 @@ def get_version(
 
 
 def parse_tag_regex(tag_regex: str | Pattern[str]) -> Pattern[str]:
+    """Pre-validate and convert tag_regex to Pattern before Configuration.
+
+    This ensures get_version() emits the deprecation warning for empty strings
+    before Configuration.__post_init__ runs.
+    """
     if isinstance(tag_regex, str):
         if tag_regex == "":
-            warnings.warn(EMPTY_TAG_REGEX_DEPRECATION)
+            warnings.warn(EMPTY_TAG_REGEX_DEPRECATION, stacklevel=3)
             return _config.DEFAULT_TAG_REGEX
         else:
             return re.compile(tag_regex)

src/setuptools_scm/_file_finders/git.py

@@ -39,7 +39,7 @@ def _git_toplevel(path: str) -> str | None:
             # ``cwd`` is absolute path to current working directory.
             # the below method removes the length of ``out`` from
             # ``cwd``, which gives the git toplevel
-            from .._compat import strip_path_suffix
+            from vcs_versioning._compat import strip_path_suffix
 
             out = strip_path_suffix(cwd, out, f"cwd={cwd!r}\nout={out!r}")
         log.debug("find files toplevel %s", out)

src/setuptools_scm/_get_version_impl.py

@@ -23,15 +23,12 @@ def get_version(root: str | PathLike[str] | None = None, **kwargs: object) -> st
         root: Optional root directory (can be passed as positional arg for backward compat)
         **kwargs: Additional configuration parameters
     """
-    from vcs_versioning.config import Configuration
+    from vcs_versioning._get_version_impl import get_version as _vcs_get_version
 
     if root is not None:
         kwargs["root"] = root
-    config = Configuration(**kwargs)  # type: ignore[arg-type]
-    version = _get_version(config, force_write_version_files=False)
-    if version is None:
-        raise RuntimeError("Unable to determine version")
-    return version
+    # Delegate to vcs_versioning's get_version which handles all validation including tag_regex
+    return _vcs_get_version(**kwargs)  # type: ignore[arg-type]
 
 
 __all__ = [

testing/test_git.py

@@ -508,7 +508,7 @@ def test_git_getdate_badgit(
     git_wd = git.GitWorkdir(wd.cwd)
     fake_date_result = CompletedProcess(args=[], stdout="%cI", stderr="", returncode=0)
     with patch.object(
-        git,
+        _git,
         "run_git",
         Mock(return_value=fake_date_result),
     ):
@@ -524,7 +524,7 @@ def test_git_getdate_git_2_45_0_plus(
         args=[], stdout="2024-04-30T22:33:10Z", stderr="", returncode=0
     )
     with patch.object(
-        git,
+        _git,
         "run_git",
         Mock(return_value=fake_date_result),
     ):