pylock: read upload_time

Author: sbidoul

src/pip/_internal/models/pylock.py

@@ -3,6 +3,7 @@
 import re
 import sys
 from dataclasses import dataclass
+from datetime import datetime
 from pathlib import Path
 from typing import (
     TYPE_CHECKING,
@@ -271,7 +272,7 @@ class PackageArchive:
     url: Optional[str]
     path: Optional[str]
     size: Optional[int]
-    # (not supported) upload_time: Optional[datetime]
+    upload_time: Optional[datetime]
     hashes: Dict[str, str]
     subdirectory: Optional[str]
 
@@ -285,6 +286,7 @@ def from_dict(cls, d: Dict[str, Any]) -> "Self":
             url=_get(d, str, "url"),
             path=_get(d, str, "path"),
             size=_get(d, int, "size"),
+            upload_time=_get(d, datetime, "upload-time"),
             hashes=_get_required(d, dict, "hashes"),
             subdirectory=_get(d, str, "subdirectory"),
         )
@@ -293,7 +295,7 @@ def from_dict(cls, d: Dict[str, Any]) -> "Self":
 @dataclass
 class PackageSdist:
     name: str
-    # (not supported) upload_time: Optional[datetime]
+    upload_time: Optional[datetime]
     url: Optional[str]
     path: Optional[str]
     size: Optional[int]
@@ -307,6 +309,7 @@ def __post_init__(self) -> None:
     def from_dict(cls, d: Dict[str, Any]) -> "Self":
         return cls(
             name=_get_required(d, str, "name"),
+            upload_time=_get(d, datetime, "upload-time"),
             url=_get(d, str, "url"),
             path=_get(d, str, "path"),
             size=_get(d, int, "size"),
@@ -317,7 +320,7 @@ def from_dict(cls, d: Dict[str, Any]) -> "Self":
 @dataclass
 class PackageWheel:
     name: str
-    # (not supported) upload_time: Optional[datetime]
+    upload_time: Optional[datetime]
     url: Optional[str]
     path: Optional[str]
     size: Optional[int]
@@ -331,6 +334,7 @@ def __post_init__(self) -> None:
     def from_dict(cls, d: Dict[str, Any]) -> "Self":
         wheel = cls(
             name=_get_required(d, str, "name"),
+            upload_time=_get(d, datetime, "upload-time"),
             url=_get(d, str, "url"),
             path=_get(d, str, "path"),
             size=_get(d, int, "size"),

src/pip/_internal/utils/pylock.py

@@ -62,6 +62,7 @@ def _pylock_package_from_install_requirement(
                 url=download_info.url,
                 path=None,
                 size=None,  # not supported
+                upload_time=None,  # not supported
                 hashes=download_info.info.hashes,
                 subdirectory=download_info.subdirectory,
             )
@@ -78,6 +79,7 @@ def _pylock_package_from_install_requirement(
                 package_wheels = [
                     PackageWheel(
                         name=link.filename,
+                        upload_time=None,  # not supported
                         url=download_info.url,
                         path=None,
                         size=None,  # not supported
@@ -87,6 +89,7 @@ def _pylock_package_from_install_requirement(
             else:
                 package_sdist = PackageSdist(
                     name=link.filename,
+                    upload_time=None,  # not supported
                     url=download_info.url,
                     path=None,
                     size=None,  # not supported

tests/unit/test_pylock.py

@@ -1,3 +1,4 @@
+from datetime import datetime
 from pathlib import Path
 
 import pytest
@@ -239,6 +240,7 @@ def test_pylock_tool() -> None:
                 "sdist": {
                     "name": "example-1.0.tar.gz",
                     "path": "./example-1.0.tar.gz",
+                    "upload-time": datetime(2023, 10, 1, 0, 0),
                     "hashes": {"sha256": "f" * 40},
                 },
                 "tool": {"pip": {"foo": "bar"}},