Prevent syntax error when keys are not Python identifiers (#79)

For now just filter these out.

Author: hoodmane

type-generation/src/astToIR.ts

@@ -34,6 +34,7 @@ import {
   getExpressionTypeArgs,
   getNodeLocation,
   groupMembers,
+  isValidPythonIdentifier,
 } from "./astUtils";
 import { sanitizeReservedWords, uniqBy } from "./irToString";
 import { Needed } from "./types";
@@ -792,15 +793,15 @@ export class Converter {
         const spread = !!param.getDotDotDotToken();
         const optional = !!param.hasQuestionToken();
         const name = param.getName();
-        const isValidPythonIdentifier = /^[a-zA-Z_$][a-zA-Z0-9_]*$/.test(name);
+        const isIdentifier = isValidPythonIdentifier(name);
         const oldNameContext = this.nameContext?.slice();
         const paramType = param.getTypeNode()!;
         const isLast = idx === params.length - 1;
         if (isLast && Node.isTypeLiteral(paramType)) {
           // If it's the last argument and the type is a type literal, we'll
           // destructure it so don't make a type.
           this.nameContext = undefined;
-        } else if (isValidPythonIdentifier) {
+        } else if (isIdentifier) {
           this.pushNameContext(name);
         } else {
           this.nameContext = undefined;
@@ -1119,10 +1120,12 @@ export class Converter {
         isStatic: false,
       });
       const irProps = ([] as PropertyIR[]).concat(
-        astProperties.map((prop) => this.propertySignatureToIR(prop, false)),
-        staticAstProperties.map((prop) =>
-          this.propertySignatureToIR(prop, true),
-        ),
+        astProperties
+          .filter((x) => isValidPythonIdentifier(x.getName()))
+          .map((prop) => this.propertySignatureToIR(prop, false)),
+        staticAstProperties
+          .filter((x) => isValidPythonIdentifier(x.getName()))
+          .map((prop) => this.propertySignatureToIR(prop, true)),
       );
       const props = uniqBy(irProps, ({ name }) => name);
       return {

type-generation/src/astUtils.ts

@@ -272,3 +272,7 @@ export function classifyIdentifier(ident: Identifier): ClassifiedIdentifier {
   }
   throw new Error("Unrecognized ident!");
 }
+
+export function isValidPythonIdentifier(name: string): boolean {
+  return /^[a-zA-Z_$][a-zA-Z0-9_]*$/.test(name);
+}

type-generation/tests/a.test.ts

@@ -2003,6 +2003,25 @@ describe("emit", () => {
         `).trim(),
       );
     });
+    it("Type literal with keys that aren't identifiers", () => {
+      // Maybe we can do something with typed-dict for this? For now, just
+      // filter them out.
+      const res = emitFile(`
+        interface T {
+          "x-y": { x:  string; };
+        };
+        declare function f(): T;
+      `);
+      assert.strictEqual(
+        removeTypeIgnores(res.slice(1).join("\n\n")),
+        dedent(`
+          def f() -> T_iface: ...
+
+          class T_iface(Protocol):
+              pass
+        `).trim(),
+      );
+    });
   });
   it("inheriting from jsobject is also jsobject", () => {
     const res = emitFile(`