Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 26, 2025

Description

Combines two separate tests for contributions_over_time data parameter handling into a single parametrized test using pytest.mark.parametrize.

Before:

def test_contributions_over_time_accepts_data_parameter(mock_posterior_data):
    ...

def test_contributions_over_time_data_parameter_fallback(mock_idata_with_posterior):
    ...

After:

@pytest.mark.parametrize(
    "use_explicit_data",
    [
        pytest.param(True, id="explicit_data_parameter"),
        pytest.param(False, id="fallback_to_idata"),
    ],
)
def test_contributions_over_time_data_parameter(
    use_explicit_data, mock_posterior_data, mock_idata_with_posterior
):
    ...

Related Issue

Checklist


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: williambdean <57733339+williambdean@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback: combine tests using pytest.mark.parametrize Address feedback: Combine tests using pytest.mark.parametrize Nov 26, 2025
Copilot AI requested a review from williambdean November 26, 2025 07:23
@github-actions github-actions bot added the tests label Nov 26, 2025
@juanitorduz juanitorduz marked this pull request as ready for review November 28, 2025 09:54
@juanitorduz juanitorduz merged commit e9a05ba into feature/mmmplotsuite-arviz Nov 28, 2025
2 of 4 checks passed
@juanitorduz juanitorduz deleted the copilot/sub-pr-2098 branch November 28, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants