Update Travis config, add lint and format checks to tests

Author: brandonwillard

.pylintrc

@@ -263,7 +263,7 @@ ignore-mixin-members=yes
 # (useful for modules/projects where namespaces are manipulated during runtime
 # and thus existing member attributes cannot be deduced by static analysis. It
 # supports qualified module names, as well as Unix pattern matching.
-ignored-modules=tensorflow.core.framework,tensorflow.python.framework,tensorflow.python.ops.gen_linalg_ops
+ignored-modules=tensorflow.core.framework,tensorflow.python.framework,tensorflow.python.ops.gen_linalg_ops,tensorflow.python.eager.context,tensorflow.compat.v1
 
 # List of classes names for which member attributes should not be checked
 # (useful for classes with attributes dynamically set). This supports can work

.travis.yml

@@ -1,25 +1,23 @@
 dist: xenial
 language: python
 
-matrix:
-  include:
-  - name: "Python 3.6 Lint"
-    python: 3.6
-    env: PYTHON_VERSION=3.6 NAME="LINT"
-  - name: "Python 3.6 Unit Test"
-    python: 3.6
-    env: PYTHON_VERSION=3.6 NAME="UNIT"
+python:
+  - "3.6"
+  - "3.7"
+  # No tf-nightly for this version
+  # - "3.8"
+  # Cython and/or Numpy fails with permission errors
+  # - "pypy3"
 
 install:
   - pip install -r requirements.txt
-  - pip freeze
 
 script:
-  - if [[ $NAME == UNIT ]]; then pytest -v tests/ --cov=symbolic_pymc/; fi
-  - if [[ $NAME == LINT ]]; then make lint; fi
+  - pylint symbolic_pymc/ tests/
+  - if [[ `command -v black` ]]; then
+      black --check symbolic_pymc tests;
+    fi
+  - pytest -v tests/ --cov=symbolic_pymc/
 
 after_success:
-  - echo $(pwd)
-  - ls -la
-  - if [[ $NAME == UNIT ]]; then sed -i 's/\/opt\/symbolic-pymc/\/home\/travis\/build\/pymc-devs\/symbolic-pymc/g' .coverage; fi
-  - if [[ $NAME == UNIT ]]; then coveralls; fi
+  - coveralls

Makefile

@@ -51,11 +51,11 @@ format:
 
 style:
 	@printf "Checking code style with pylint...\n"
-	pylint symbolic_pymc/
+	pylint symbolic_pymc/ tests/
 	@printf "\033[1;34mPylint passes!\033[0m\n\n"
 
 black:  # Format code in-place using black.
-	black symbolic_pymc/
+	black symbolic_pymc/ tests/
 
 test:  # Test code using pytest.
 	pytest -v tests/ --cov=symbolic_pymc/ --cov-report=xml --html=testing-report.html --self-contained-html

tests/tensorflow/__init__.py

@@ -7,4 +7,5 @@ def run_in_graph_mode(f):
     def _f(*args, **kwargs):
         with graph_mode():
             return f()
+
     return _f

tests/tensorflow/conftest.py

@@ -14,6 +14,7 @@ def setup_module():
 
     # Let's make sure we have a clean graph slate
     from tensorflow.compat.v1 import reset_default_graph
+
     reset_default_graph()
 
     yield

tests/tensorflow/test_kanren.py

@@ -11,18 +11,18 @@
 
 @run_in_graph_mode
 def test_commutativity():
-    with enable_lvar_defaults('names'):
+    with enable_lvar_defaults("names"):
         add_1_mt = mt(1) + mt(2)
         add_2_mt = mt(2) + mt(1)
 
-    res = run(0, var('q'), commutative(add_1_mt.base_operator))
+    res = run(0, var("q"), commutative(add_1_mt.base_operator))
     assert res is not False
 
-    res = run(0, var('q'), eq_comm(add_1_mt, add_2_mt))
+    res = run(0, var("q"), eq_comm(add_1_mt, add_2_mt))
     assert res is not False
 
-    with enable_lvar_defaults('names'):
-        add_pattern_mt = mt(2) + var('q')
+    with enable_lvar_defaults("names"):
+        add_pattern_mt = mt(2) + var("q")
 
-    res = run(0, var('q'), eq_comm(add_1_mt, add_pattern_mt))
+    res = run(0, var("q"), eq_comm(add_1_mt, add_pattern_mt))
     assert res[0] == add_1_mt.base_arguments[0]