Fix segfault bug in Alloc C implementation

Author: ricardoV94

pytensor/tensor/basic.py

@@ -1506,7 +1506,7 @@ def c_code(self, node, name, inp, out, sub):
             if (need_new_out)
             {{
                 Py_XDECREF({zz});
-                {zz} = (PyArrayObject*) PyArray_SimpleNew({ndim}, shape, PyArray_TYPE((PyArrayObject*) py_{vv}));
+                {zz} = (PyArrayObject*) PyArray_SimpleNew({ndim}, shape, PyArray_TYPE({vv}));
                 if (!{zz})
                 {{
                     PyErr_SetString(PyExc_MemoryError, "alloc failed");
@@ -1522,7 +1522,7 @@ def c_code(self, node, name, inp, out, sub):
         return code
 
     def c_code_cache_version(self):
-        return (2,)
+        return (3,)
 
     def infer_shape(self, fgraph, node, input_shapes):
         return [node.inputs[1:]]

tests/tensor/test_basic.py

@@ -14,7 +14,7 @@
 from pytensor.compile.mode import Mode, get_default_mode
 from pytensor.compile.ops import DeepCopyOp
 from pytensor.gradient import grad, hessian
-from pytensor.graph.basic import Apply
+from pytensor.graph.basic import Apply, equal_computations
 from pytensor.graph.op import Op
 from pytensor.graph.replace import clone_replace
 from pytensor.misc.safe_asarray import _asarray
@@ -719,6 +719,7 @@ class TestAlloc:
     shared = staticmethod(pytensor.shared)
     allocs = [Alloc()] * 3
 
+
     def setup_method(self):
         self.rng = np.random.default_rng(seed=utt.fetch_seed())
 
@@ -850,6 +851,19 @@ def test_static_shape(self):
         with pytest.raises(ValueError, match=msg):
             at.alloc(x, 3, 1, 6)
 
+    def test_alloc_of_view_linker(self):
+        """Check we can allocate a new array properly in the C linker when input is a view."""
+        x_v = vector("x", shape=(None,))
+        dim_len = scalar("dim_len", dtype=int)
+        out = alloc(specify_shape(x_v, (1,)), 5, dim_len)
+
+        f = pytensor.function([x_v, dim_len], out, mode=Mode("c"))
+        assert equal_computations(
+            f.maker.fgraph.outputs, [alloc(specify_shape(x_v, (1,)), 5, dim_len)]
+        )
+
+        np.testing.assert_array_equal(f(x=np.zeros((1,)), dim_len=3), np.zeros((5, 3)))
+
 
 def test_infer_shape():
     with pytest.raises(TypeError, match="^Shapes must be scalar integers.*"):