Do not try to infer artificial connection patterns in OpFromGraph

Author: ricardoV94

pytensor/compile/builders.py

@@ -890,30 +890,9 @@ def connection_pattern(self, node):
         if self._connection_pattern is not None:
             return self._connection_pattern
 
-        inp_len = len(self.inner_inputs)
-        out_len = len(self.inner_outputs)
-        cpmat_self = io_connection_pattern(self.inner_inputs, self.inner_outputs)
-
-        lop_op = self.get_lop_op()
-        cpmat_grad = io_connection_pattern(
-            lop_op.inner_inputs[inp_len:], lop_op.inner_outputs
-        )
-
-        # cpmat_self |= cpmat_grad.T
-        # cpmat_self &= out_is_disconnected
-        for i, t in enumerate(self._lop_op_stypes_l):
-            if t is not None:
-                if isinstance(t.type, DisconnectedType):
-                    for o in range(out_len):
-                        cpmat_self[i][o] = False
-            for o in range(out_len):
-                cpmat_self[i][o] |= cpmat_grad[o][i]
-
-        # TODO in case DisconnectedType is implemented for R_op,
-        # self._rop_op_stypes_l self._rop_op should considered for
-        # connection_pattern
-
-        return list(map(list, cpmat_self))
+        ret = io_connection_pattern(self.inner_inputs, self.inner_outputs)
+        self._connection_pattern = ret
+        return ret
 
     def infer_shape(self, fgraph, node, shapes):
         # TODO: Use `fgraph.shape_feature` to do this instead.

tests/compile/test_builders.py

@@ -244,6 +244,8 @@ def go2(inps, gs):
                 [x, w, b],
                 [x * w + b],
                 grad_overrides=[go1, NullType()(), DisconnectedType()()],
+                # This is a fake override, so a fake connection_pattern must be provided as well
+                connection_pattern=[[True], [True], [False]],
             )
         zz2 = pt_sum(op_linear2(xx, ww, bb))
         dx2, dw2, db2 = grad(