Fix _make_nice_attr_error_ for random and add it to SymbolicDistributions

Author: ricardoV94

pymc/distributions/distribution.py

@@ -292,7 +292,7 @@ def __new__(
 
         rv_out.logp = _make_nice_attr_error("rv.logp(x)", "pm.logp(rv, x)")
         rv_out.logcdf = _make_nice_attr_error("rv.logcdf(x)", "pm.logcdf(rv, x)")
-        rv_out.random = _make_nice_attr_error("rv.random()", "rv.eval()")
+        rv_out.random = _make_nice_attr_error("rv.random()", "pm.draw(rv)")
         return rv_out
 
     @classmethod
@@ -351,7 +351,7 @@ def dist(
 
         rv_out.logp = _make_nice_attr_error("rv.logp(x)", "pm.logp(rv, x)")
         rv_out.logcdf = _make_nice_attr_error("rv.logcdf(x)", "pm.logcdf(rv, x)")
-        rv_out.random = _make_nice_attr_error("rv.random()", "rv.eval()")
+        rv_out.random = _make_nice_attr_error("rv.random()", "pm.draw(rv)")
         return rv_out
 
 
@@ -488,6 +488,10 @@ def __new__(
             functools.partial(str_for_symbolic_dist, formatting="latex"), rv_out
         )
 
+        rv_out.logp = _make_nice_attr_error("rv.logp(x)", "pm.logp(rv, x)")
+        rv_out.logcdf = _make_nice_attr_error("rv.logcdf(x)", "pm.logcdf(rv, x)")
+        rv_out.random = _make_nice_attr_error("rv.random()", "pm.draw(rv)")
+
         return rv_out
 
     @classmethod
@@ -546,10 +550,9 @@ def dist(
         # This is needed for resizing from dims in `__new__`
         rv_out.tag.ndim_supp = ndim_supp
 
-        # TODO: Create new attr error stating that these are not available for DerivedDistribution
-        # rv_out.logp = _make_nice_attr_error("rv.logp(x)", "pm.logp(rv, x)")
-        # rv_out.logcdf = _make_nice_attr_error("rv.logcdf(x)", "pm.logcdf(rv, x)")
-        # rv_out.random = _make_nice_attr_error("rv.random()", "rv.eval()")
+        rv_out.logp = _make_nice_attr_error("rv.logp(x)", "pm.logp(rv, x)")
+        rv_out.logcdf = _make_nice_attr_error("rv.logcdf(x)", "pm.logcdf(rv, x)")
+        rv_out.random = _make_nice_attr_error("rv.random()", "pm.draw(rv)")
         return rv_out
 
 

pymc/tests/test_distributions.py

@@ -3145,7 +3145,7 @@ def test_distinct_rvs():
     [
         ("logp", r"pm.logp\(rv, x\)"),
         ("logcdf", r"pm.logcdf\(rv, x\)"),
-        ("random", r"rv.eval\(\)"),
+        ("random", r"pm.draw\(rv\)"),
     ],
 )
 def test_logp_gives_migration_instructions(method, newcode):