Deal with deprecation warning (#4547)

* Make backend compatibility check more robust

And deal with deprecation warning (closes #4546).

* Remove undefined plot_posterior from __all__ because it's already in az.plots.__all__

Pylint complained about it.

Author: michaelosthege

pymc3/__init__.py

@@ -31,14 +31,29 @@
         _log.addHandler(handler)
 
 
-if not semver.match(theano.__version__, ">=1.1.2"):
-    print(
-        "!" * 60
-        + f"\nThe installed Theano(-PyMC) version ({theano.__version__}) does not match the PyMC3 requirements."
-        + "\nFor PyMC3 to work, Theano must be uninstalled and replaced with Theano-PyMC."
-        + "\nSee https://github.com/pymc-devs/pymc3/wiki for installation instructions.\n"
-        + "!" * 60
-    )
+def _check_backend_version():
+    backend_paths = theano.__spec__.submodule_search_locations
+    try:
+        backend_version = theano.__version__
+    except:
+        print(
+            "!" * 60
+            + f"\nThe imported Theano(-PyMC) module is broken."
+            + f"\nIt was imported from {backend_paths}"
+            + "\nTry to uninstall/reinstall it after closing all active sessions/notebooks."
+            + "\nAlso see https://github.com/pymc-devs/pymc3/wiki for installation instructions.\n"
+            + "!" * 60
+        )
+        return
+    if not semver.VersionInfo.parse(backend_version).match(">=1.1.2"):
+        print(
+            "!" * 60
+            + f"\nThe installed Theano(-PyMC) version ({theano.__version__}) does not match the PyMC3 requirements."
+            + f"\nIt was imported from {backend_paths}"
+            + "\nFor PyMC3 to work, a compatible Theano-PyMC backend version must be installed."
+            + "\nSee https://github.com/pymc-devs/pymc3/wiki for installation instructions.\n"
+            + "!" * 60
+        )
 
 
 def __set_compiler_flags():
@@ -47,6 +62,7 @@ def __set_compiler_flags():
     theano.config.gcc__cxxflags = f"{current} -Wno-c++11-narrowing"
 
 
+_check_backend_version()
 __set_compiler_flags()
 
 from pymc3 import gp, ode, sampling

pymc3/plots/__init__.py

@@ -117,7 +117,6 @@ def compareplot(*args, **kwargs):
     "compareplot",
     "forestplot",
     "kdeplot",
-    "plot_posterior",
     "traceplot",
     "energyplot",
     "densityplot",

pymc3/tests/test_util.py

@@ -14,6 +14,7 @@
 
 import numpy as np
 import pytest
+import theano
 
 from cachetools import cached
 from numpy.testing import assert_almost_equal
@@ -25,6 +26,27 @@
 from pymc3.util import hash_key, hashable, locally_cachedmethod
 
 
+class TestBackendVersionCheck:
+    def test_warn_on_incompatible_backend(self, capsys):
+        assert not "!!!!!" in capsys.readouterr().out
+        pm._check_backend_version()
+        assert not "!!!!!" in capsys.readouterr().out
+
+        # Mock an incorrect backend version
+        original = theano.__version__
+
+        theano.__version__ = "1.1.0"
+        pm._check_backend_version()
+        assert "does not match" in capsys.readouterr().out
+
+        del theano.__version__
+        pm._check_backend_version()
+        assert "is broken" in capsys.readouterr().out
+
+        theano.__version__ = original
+        pass
+
+
 class TestTransformName:
     cases = [("var", "var_test__"), ("var_test_", "var_test__test__")]
     transform_name = "test"

requirements.txt

@@ -6,6 +6,6 @@ numpy>=1.15.0
 pandas>=0.24.0
 patsy>=0.5.1
 scipy>=1.2.0
-semver
+semver>=2.13.0
 theano-pymc==1.1.2
 typing-extensions>=3.7.4