More functional test using options

Pierre-Sassoulas · Pierre-Sassoulas · commit 1c775bf645d2 · 2025-06-18T22:26:02.000+02:00
diff --git a/doc/data/messages/b/bad-float-notation/bad/engineering_notation.rc b/doc/data/messages/b/bad-float-notation/bad/engineering_notation.rc
@@ -0,0 +1,2 @@
+[main]
+strict-engineering-notation = true
diff --git a/doc/data/messages/b/bad-float-notation/bad/pep515.rc b/doc/data/messages/b/bad-float-notation/bad/pep515.rc
@@ -0,0 +1,2 @@
+[main]
+strict-underscore-notation = true
diff --git a/doc/data/messages/b/bad-float-notation/bad/scientific_notation.rc b/doc/data/messages/b/bad-float-notation/bad/scientific_notation.rc
@@ -0,0 +1,2 @@
+[main]
+strict-scientific-notation = true
diff --git a/doc/data/messages/b/bad-float-notation/details.rst b/doc/data/messages/b/bad-float-notation/details.rst
@@ -0,0 +1,6 @@
+There's 4 options associated with this message:
+- ``strict-engineering-notation``
+- ``strict-scientific-notation``
+- ``strict-underscore-notation``
+- ``threshold``
+By default we allow all three standard and the threshold is high.
diff --git a/doc/data/messages/b/bad-float-notation/good/engineering_notation.py b/doc/data/messages/b/bad-float-notation/good/engineering_notation.py
@@ -1,3 +1,3 @@
 exponent_multiple_of_three = 1.23e6
-base_between_one_and_a_thousand = 12.345e9  # [bad-float-notation]
-under_a_thousand = 990  # [bad-float-notation]
+base_between_one_and_a_thousand = 12.345e9
+under_a_thousand = 990
diff --git a/doc/data/messages/b/bad-float-notation/related.rst b/doc/data/messages/b/bad-float-notation/related.rst
@@ -0,0 +1 @@
+- `PEP 515 <https://docs.python.org/3/library/string.html#formatstrings>`_
diff --git a/doc/test_messages_documentation.py b/doc/test_messages_documentation.py
@@ -173,7 +173,9 @@ def _runTest(self) -> None:
             assert len(actual_messages_raw) >= len(bad_files), self.assert_message_bad(
                 bad_files, actual_messages_raw
             )
-        assert expected_messages == self._get_actual(actual_messages_raw)
+        actual = self._get_actual(actual_messages_raw)
+        assert_msg = f"Expected {expected_messages!r} and got {actual!r} in {self._test_file[1]}."
+        assert expected_messages == actual, assert_msg
 
     def assert_message_good(self, messages: list[Message]) -> str:
         good = self._test_file[1]
diff --git a/tests/functional/b/bad_float/bad_float_engineering_notation.py b/tests/functional/b/bad_float/bad_float_engineering_notation.py
@@ -0,0 +1,9 @@
+# pylint: disable=missing-docstring,invalid-name
+
+exponent_not_multiple_of_three = 123e4  # [bad-float-notation]
+base_not_between_one_and_a_thousand = 12345e6  # [bad-float-notation]
+above_threshold_without_exponent = 10000000  # [bad-float-notation]
+under_a_thousand_with_exponent = 9.9e2  # [bad-float-notation]
+exponent_multiple_of_three = 1.23e6
+base_between_one_and_a_thousand = 12.345e9
+under_a_thousand = 990
diff --git a/tests/functional/b/bad_float/bad_float_engineering_notation.rc b/tests/functional/b/bad_float/bad_float_engineering_notation.rc
@@ -0,0 +1,4 @@
+[main]
+strict-engineering-notation = true
+strict-scientific-notation = false
+strict-underscore-notation = false
diff --git a/tests/functional/b/bad_float/bad_float_notation_default.py b/tests/functional/b/bad_float/bad_float_notation_default.py
@@ -1,5 +1,10 @@
 # pylint: disable=missing-docstring,invalid-name
 
+mindless_anarchy = 1504e5  # [bad-float-notation]
+scientific_notation = 1.504e8
+engineering_notation = 150.4e6
+underscore_notation = 150_400_000
+
 wrong_big = 45.3e6  # [bad-float-notation]
 uppercase_e_wrong = 45.3E6  # [bad-float-notation]
 wrong_small = 0.00012e-26  # [bad-float-notation]
diff --git a/tests/functional/b/bad_float/bad_float_notation_default.rc b/tests/functional/b/bad_float/bad_float_notation_default.rc
@@ -0,0 +1,4 @@
+[main]
+strict-engineering-notation = false
+strict-scientific-notation = false
+strict-underscore-notation = false
diff --git a/tests/functional/b/bad_float/bad_float_notation_default.txt b/tests/functional/b/bad_float/bad_float_notation_default.txt
diff --git a/tests/functional/b/bad_float/bad_float_pep515.py b/tests/functional/b/bad_float/bad_float_pep515.py
@@ -0,0 +1,8 @@
+# pylint: disable=missing-docstring,invalid-name
+
+not_grouped_by_three = 1_23_456_7_89  # [bad-float-notation]
+mixing_with_exponent = 1_23_4_5_67_8e9  # [bad-float-notation]
+above_threshold_without_grouping = 123456789  # [bad-float-notation]
+proper_grouping = 123_456_789
+scientific_notation = 1.2345678e16
+engineering_notation = 12.345678e15
diff --git a/tests/functional/b/bad_float/bad_float_pep515.rc b/tests/functional/b/bad_float/bad_float_pep515.rc
@@ -0,0 +1,4 @@
+[main]
+strict-engineering-notation = false
+strict-scientific-notation = false
+strict-underscore-notation = true
diff --git a/tests/functional/b/bad_float/bad_float_scientific_notation.py b/tests/functional/b/bad_float/bad_float_scientific_notation.py
@@ -0,0 +1,8 @@
+# pylint: disable=missing-docstring,invalid-name
+
+base_not_between_one_and_ten = 10e3  # [bad-float-notation]
+above_threshold_without_exponent = 10000000  # [bad-float-notation]
+under_ten_with_exponent = 9.9e0  # [bad-float-notation]
+base_between_one_and_ten = 1e4
+above_threshold_with_exponent = 1e7
+under_ten = 9.9
diff --git a/tests/functional/b/bad_float/bad_float_scientific_notation.rc b/tests/functional/b/bad_float/bad_float_scientific_notation.rc
@@ -0,0 +1,4 @@
+[main]
+strict-engineering-notation = false
+strict-scientific-notation = true
+strict-underscore-notation = false

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+[main]`
	`2`	`+strict-engineering-notation = true`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+[main]`
	`2`	`+strict-underscore-notation = true`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+[main]`
	`2`	`+strict-scientific-notation = true`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+- `PEP 515 <https://docs.python.org/3/library/string.html#formatstrings>`_