(Manually) Update MyPy

* Ignore `IAstroidChecker` typing "error"
* `CustomVariablesChecker#add_message`: x
  * `Confidence` type,
  * separate-module `NodeNG` import
  * `from __future__ import annotations`
* Make `tests/` a module
* `BasePytestTester#IMPACTED_CHECKER_CLASSES`:
  It's a `list[type[BaseChecker]]`, not a `list[BaseChecker]` itself
* Add MOAR `tool.mypy.exclude`s (for clean interactive `mypy` execution)

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

Author: stdedos

.pre-commit-config.yaml

@@ -74,10 +74,12 @@ repos:
         language: pygrep
         types: [python]
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.8.0
+    rev: v1.10.1
     hooks:
       - id: mypy
         exclude: tests/input/
+        additional_dependencies:
+          - pylint
   - repo: local
     hooks:
       - id: pylint

pylint_pytest/checkers/__init__.py

@@ -9,7 +9,9 @@ class BasePytestChecker(BaseChecker):
         # Since https://github.com/pylint-dev/pylint/pull/8404, pylint does not need this
         # __implements__ pattern. keeping it for retro compatibility with pylint==2.x
         # pylint: disable=import-outside-toplevel,no-name-in-module
-        from pylint.interfaces import IAstroidChecker
+        from pylint.interfaces import (  # type: ignore[attr-defined] # It is defined in pylint~=2
+            IAstroidChecker,
+        )
 
         __implements__ = IAstroidChecker
 

pylint_pytest/checkers/variables.py

@@ -1,7 +1,8 @@
-from typing import Any, Optional
+from __future__ import annotations
 
-from astroid import Arguments, Module
-from astroid.nodes.node_ng import NodeNG
+from typing import Any
+
+from astroid import Arguments, Module, NodeNG
 from pylint.checkers.variables import VariablesChecker
 from pylint.interfaces import Confidence
 
@@ -19,13 +20,13 @@ class CustomVariablesChecker(VariablesChecker):
     def add_message(
         self,
         msgid: str,
-        line: Optional[int] = None,
-        node: Optional[NodeNG] = None,
+        line: int | None = None,
+        node: NodeNG | None = None,
         args: Any = None,
-        confidence: Confidence = None,
-        col_offset: Optional[int] = None,
-        end_lineno: Optional[int] = None,
-        end_col_offset: Optional[int] = None,
+        confidence: Confidence | None = None,
+        col_offset: int | None = None,
+        end_lineno: int | None = None,
+        end_col_offset: int | None = None,
     ) -> None:
         """
         - intercept and discard unwanted warning messages

pyproject.toml

@@ -117,7 +117,9 @@ exclude = [
     "^.venv",       # Ignore installed packages
     "^.tox",        # Ignore tox virtualenvs
     "^.cache",      # Ignore CI-defined .cache
-    "^tests/input/" # Ignore test inputs
+    "^tests/input/", # Ignore test inputs
+    "^build/",      # Ignore build inputs
+    "^dist/",       # Ignore build inputs
 ]
 
 [[tool.mypy.overrides]]

tests/__init__.py

@@ -24,7 +24,7 @@ def get_test_root_path() -> Path:
 
 class BasePytestTester(ABC):
     CHECKER_CLASS = BaseChecker
-    IMPACTED_CHECKER_CLASSES: list[BaseChecker] = []
+    IMPACTED_CHECKER_CLASSES: list[type[BaseChecker]] = []
     MSG_ID: str
     msgs: list[MessageTest] = []
 

tests/base_tester.py

@@ -1,5 +1,6 @@
 import pytest
-from base_tester import BasePytestTester, get_test_root_path
+
+from .base_tester import BasePytestTester, get_test_root_path
 
 # pylint: disable=unused-variable
 

tests/base_tester_test.py

@@ -1,10 +1,12 @@
 import re
+from collections.abc import Sequence
 
 import pytest
-from base_tester import BasePytestTester
 
 from pylint_pytest.checkers.fixture import FixtureChecker
 
+from .base_tester import BasePytestTester
+
 
 class TestCannotEnumerateFixtures(BasePytestTester):
     CHECKER_CLASS = FixtureChecker
@@ -18,6 +20,9 @@ def test_no_such_package(self, enable_plugin):
         if enable_plugin:
             msg = self.msgs[0]
 
+            assert isinstance(msg.args, Sequence)
+            assert len(msg.args) == 3
+
             # Asserts/Fixes duplicate filenames in output:
             # https://github.com/reverbc/pylint-pytest/pull/22/files#r698204470
             filename_arg = msg.args[0]
@@ -28,7 +33,7 @@ def test_no_such_package(self, enable_plugin):
 
             # Assert `stdout` is non-empty.
             assert msg.args[1]
-            # Assert `stderr` is empty (pytest runs stably, even though fixture collection fails).
+            # Assert `stderr` is empty (pytest runs stably, even if the fixture collection fails).
             assert not msg.args[2]
 
     @pytest.mark.parametrize("enable_plugin", [True, False])
@@ -39,6 +44,9 @@ def test_import_corrupted_module(self, enable_plugin):
         if enable_plugin:
             msg = self.msgs[0]
 
+            assert isinstance(msg.args, Sequence)
+            assert len(msg.args) == 3
+
             # ... somehow, since `import_corrupted_module.py` imports `no_such_package.py`
             # both of their names are returned in the message.
             filename_arg = msg.args[0]

tests/test_cannot_enumerate_fixtures.py

@@ -1,9 +1,10 @@
 import pytest
-from base_tester import BasePytestTester
 from pylint.checkers.typecheck import TypeChecker
 
 from pylint_pytest.checkers.class_attr_loader import ClassAttrLoader
 
+from .base_tester import BasePytestTester
+
 
 class TestNoMember(BasePytestTester):
     CHECKER_CLASS = ClassAttrLoader

tests/test_no_member.py

@@ -1,7 +1,7 @@
-from base_tester import BasePytestTester
-
 from pylint_pytest.checkers.fixture import FixtureChecker
 
+from .base_tester import BasePytestTester
+
 
 class TestDeprecatedPytestFixtureScopeAsPositionalParam(BasePytestTester):
     CHECKER_CLASS = FixtureChecker