pre-commit run -a

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

Author: stdedos

.github/ISSUE_TEMPLATE/bug_report.md

@@ -12,7 +12,7 @@ A clear and concise description of what the bug is.
 
 **To Reproduce**
 Package versions
-- pylint 
+- pylint
 - pytest
 - pylint-pytest
 

.pre-commit-config.yaml

@@ -1,27 +1,27 @@
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
       - id: end-of-file-fixer
         exclude: ^.idea/
       - id: trailing-whitespace
       - id: pretty-format-json
         args: [ "--no-sort-keys", "--autofix", "--indent=4" ]
         exclude: ^.vscode/
-  - repo: https://github.com/asottile/pyupgrade
-    rev: v3.13.0
-    hooks:
-      - id: pyupgrade
-        args:
-          - --py36-plus
+  # - repo: https://github.com/asottile/pyupgrade
+  #   rev: v3.13.0
+  #   hooks:
+  #     - id: pyupgrade
+  #       args:
+  #         - --py36-plus
   - repo: https://github.com/PyCQA/autoflake
     rev: v2.2.1
     hooks:
       - id: autoflake
-  - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.0.285
-    hooks:
-      - id: ruff
+  # - repo: https://github.com/astral-sh/ruff-pre-commit
+  #   rev: v0.0.292
+  #   hooks:
+  #     - id: ruff
   - repo: https://github.com/pycqa/isort
     rev: 5.12.0
     hooks:
@@ -52,34 +52,34 @@ repos:
       - id: rst-directive-colons
       - id: rst-inline-touching-normal
       - id: text-unicode-replacement-char
-  - repo: https://github.com/pycqa/flake8
-    rev: 5.0.4
-    hooks:
-      - id: flake8
-        additional_dependencies:
-          - flake8-bandit
-          - flake8-bugbear
-          - flake8-class-attributes-order
-          - flake8-comprehensions
-          # - flake8-docstrings  # it is a mess to clean up; let's only warn user's IDEs instead.
-          - flake8-future-annotations
-          - flake8-noqa
-          - flake8-print
-          - flake8-pyproject
-          - flake8-pytest-style
-          - flake8-type-checking
-          - flake8-variables-names
-          - pep8-naming
-  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.6.0
-    hooks:
-      - id: mypy
-  - repo: local
-    hooks:
-      - id: pylint
-        name: pylint
-        entry: bash -c 'test -d .venv && . .venv/bin/activate ; pylint ${CI:+--reports=yes} "$@"' -
-        language: system
-        types: [ python ]
-        args:
-          - --disable=R,C
+  # - repo: https://github.com/pycqa/flake8
+  #   rev: 5.0.4
+  #   hooks:
+  #     - id: flake8
+  #       additional_dependencies:
+  #         - flake8-bandit
+  #         - flake8-bugbear
+  #         - flake8-class-attributes-order
+  #         - flake8-comprehensions
+  #         # - flake8-docstrings  # it is a mess to clean up; let's only warn user's IDEs instead.
+  #         - flake8-future-annotations
+  #         - flake8-noqa
+  #         - flake8-print
+  #         - flake8-pyproject
+  #         - flake8-pytest-style
+  #         - flake8-type-checking
+  #         - flake8-variables-names
+  #         - pep8-naming
+  # - repo: https://github.com/pre-commit/mirrors-mypy
+  #   rev: v1.6.0
+  #   hooks:
+  #     - id: mypy
+  # - repo: local
+  #   hooks:
+  #     - id: pylint
+  #       name: pylint
+  #       entry: bash -c 'test -d .venv && . .venv/bin/activate ; pylint ${CI:+--reports=yes} "$@"' -
+  #       language: system
+  #       types: [ python ]
+  #       args:
+  #         - --disable=R,C

README.md

@@ -51,7 +51,10 @@ def test_something(conftest_fixture):  # <- Unused argument 'conftest_fixture'
 FP when an imported fixture is used in an applicable function, e.g.
 
 ```python
-from fixture_collections import imported_fixture  # <- Unused imported_fixture imported from fixture_collections
+from fixture_collections import (
+    imported_fixture,
+)  # <- Unused imported_fixture imported from fixture_collections
+
 
 def test_something(imported_fixture):
     ...
@@ -64,7 +67,10 @@ FP when an imported/declared fixture is used in an applicable function, e.g.
 ```python
 from fixture_collections import imported_fixture
 
-def test_something(imported_fixture):  # <- Redefining name 'imported_fixture' from outer scope (line 1)
+
+def test_something(
+    imported_fixture,
+):  # <- Redefining name 'imported_fixture' from outer scope (line 1)
     ...
 ```
 
@@ -75,15 +81,18 @@ FP when class attributes are defined in setup fixtures
 ```python
 import pytest
 
+
 class TestClass(object):
     @staticmethod
-    @pytest.fixture(scope='class', autouse=True)
+    @pytest.fixture(scope="class", autouse=True)
     def setup_class(request):
         cls = request.cls
         cls.defined_in_setup_class = True
 
     def test_foo(self):
-        assert self.defined_in_setup_class  # <- Instance of 'TestClass' has no 'defined_in_setup_class' member
+        assert (
+            self.defined_in_setup_class
+        )  # <- Instance of 'TestClass' has no 'defined_in_setup_class' member
 ```
 
 ## Raise new warning(s)
@@ -95,6 +104,7 @@ Raise when using deprecated `@pytest.yield_fixture` decorator ([ref](https://doc
 ```python
 import pytest
 
+
 @pytest.yield_fixture  # <- Using a deprecated @pytest.yield_fixture decorator
 def yield_fixture():
     yield
@@ -107,12 +117,16 @@ Raise when using every `@pytest.mark.*` for the fixture ([ref](https://docs.pyte
 ```python
 import pytest
 
+
 @pytest.fixture
 def awesome_fixture():
     ...
 
+
 @pytest.fixture
-@pytest.mark.usefixtures("awesome_fixture")  # <- Using useless `@pytest.mark.*` decorator for fixtures
+@pytest.mark.usefixtures(
+    "awesome_fixture"
+)  # <- Using useless `@pytest.mark.*` decorator for fixtures
 def another_awesome_fixture():
     ...
 ```
@@ -124,6 +138,7 @@ Raise when using deprecated positional arguments for fixture decorator ([ref](ht
 ```python
 import pytest
 
+
 @pytest.fixture("module")  # <- Using a deprecated positional arguments for fixture
 def awesome_fixture():
     ...

pylint_pytest/__init__.py

@@ -1,29 +1,31 @@
-import os
-import inspect
-import importlib
 import glob
+import importlib
+import inspect
+import os
 
 from .checkers import BasePytestChecker
 
 
 # pylint: disable=protected-access
 def register(linter):
-    '''auto discover pylint checker classes'''
+    """auto discover pylint checker classes"""
     dirname = os.path.dirname(__file__)
-    for module in glob.glob(os.path.join(dirname, 'checkers', '*.py')):
+    for module in glob.glob(os.path.join(dirname, "checkers", "*.py")):
         # trim file extension
         module = os.path.splitext(module)[0]
 
         # use relative path only
-        module = module.replace(dirname, '', 1)
+        module = module.replace(dirname, "", 1)
 
         # translate file path into module import path
-        module = module.replace(os.sep, '.')
+        module = module.replace(os.sep, ".")
 
         checker = importlib.import_module(module, package=os.path.basename(dirname))
         for attr_name in dir(checker):
             attr_val = getattr(checker, attr_name)
-            if attr_val != BasePytestChecker and \
-                    inspect.isclass(attr_val) and \
-                    issubclass(attr_val, BasePytestChecker):
+            if (
+                attr_val != BasePytestChecker
+                and inspect.isclass(attr_val)
+                and issubclass(attr_val, BasePytestChecker)
+            ):
                 linter.register_checker(attr_val(linter))

pylint_pytest/checkers/__init__.py

@@ -2,4 +2,4 @@
 
 
 class BasePytestChecker(BaseChecker):
-    name = 'pylint-pytest'
+    name = "pylint-pytest"

pylint_pytest/checkers/class_attr_loader.py

@@ -1,19 +1,20 @@
 import astroid
 from pylint.interfaces import IAstroidChecker
+
 from ..utils import _can_use_fixture, _is_class_autouse_fixture
 from . import BasePytestChecker
 
 
 class ClassAttrLoader(BasePytestChecker):
     __implements__ = IAstroidChecker
-    msgs = {'E6400': ('', 'pytest-class-attr-loader', '')}
+    msgs = {"E6400": ("", "pytest-class-attr-loader", "")}
 
     in_setup = False
     request_cls = set()
     class_node = None
 
     def visit_functiondef(self, node):
-        '''determine if a method is a class setup method'''
+        """determine if a method is a class setup method"""
         self.in_setup = False
         self.request_cls = set()
         self.class_node = None
@@ -23,17 +24,23 @@ def visit_functiondef(self, node):
             self.class_node = node.parent
 
     def visit_assign(self, node):
-        '''store the aliases for `cls`'''
-        if self.in_setup and isinstance(node.value, astroid.Attribute) and \
-                node.value.attrname == 'cls' and \
-                node.value.expr.name == 'request':
+        """store the aliases for `cls`"""
+        if (
+            self.in_setup
+            and isinstance(node.value, astroid.Attribute)
+            and node.value.attrname == "cls"
+            and node.value.expr.name == "request"
+        ):
             # storing the aliases for cls from request.cls
             self.request_cls = set(map(lambda t: t.name, node.targets))
 
     def visit_assignattr(self, node):
-        if self.in_setup and isinstance(node.expr, astroid.Name) and \
-                node.expr.name in self.request_cls and \
-                node.attrname not in self.class_node.locals:
+        if (
+            self.in_setup
+            and isinstance(node.expr, astroid.Name)
+            and node.expr.name in self.request_cls
+            and node.attrname not in self.class_node.locals
+        ):
             try:
                 # find Assign node which contains the source "value"
                 assign_node = node