Add pandas dtyoe parameter checker

Author: Peter Hamfelt

pylint_ml/checkers/pandas/pandas_dtype_param.py

@@ -10,7 +10,7 @@ class PandasDtypeChecker(BaseChecker):
         "W8117": (
             "Specify 'dtype' when using '%s' for better performance and data integrity.",
             "pandas-dtype-param",
-            "It's recommended to explicitly specify the 'dtype' parameter in pandas read functions."
+            "It's recommended to explicitly specify the 'dtype' parameter in pandas read functions.",
         ),
     }
 
@@ -24,4 +24,4 @@ def visit_call(self, node: nodes.Call) -> None:
             if module_name == "pd" and func_name in {"read_csv", "read_excel", "read_table"}:
                 # Check if dtype is specified
                 if not any(kw.arg == "dtype" for kw in node.keywords):
-                    self.add_message("pandas-dtype-param", node=node, confidence=HIGH)
+                    self.add_message("pandas-dtype-param", node=node, confidence=HIGH)

tests/checkers/test_pandas/test_pandas_dataframe_values.py

@@ -32,18 +32,3 @@ def test_values_usage_with_correct_naming(self):
             ignore_position=True,
         ):
             self.checker.visit_attribute(attribute_node)
-
-    def test_no_warning_for_to_numpy(self):
-        node = astroid.extract_node(
-            """
-            import pandas as pd
-            df_sales = pd.DataFrame({
-                "A": [1, 2, 3],
-                "B": [4, 5, 6]
-            })
-            df_data = df_sales.to_numpy()  # This should not trigger any warnings
-            """
-        )
-
-        with self.assertNoMessages():
-            self.checker.visit_call(node)

tests/checkers/test_pandas/test_pandas_dtype_param.py

@@ -19,7 +19,7 @@ def test_dtype_specified(self):
         dtype_call = node.value
 
         with self.assertNoMessages():
-            self.checker.visit_call(node.value)
+            self.checker.visit_call(dtype_call)
 
     def test_dtype_missing(self):
         node = astroid.extract_node(
@@ -32,11 +32,11 @@ def test_dtype_missing(self):
         dtype_call = node.value
 
         with self.assertAddsMessages(
-                pylint.testutils.MessageTest(
-                    msg_id="pandas-dtype-param",
-                    confidence=HIGH,
-                    node=dtype_call,
-                ),
-                ignore_position=True,
+            pylint.testutils.MessageTest(
+                msg_id="pandas-dtype-param",
+                confidence=HIGH,
+                node=dtype_call,
+            ),
+            ignore_position=True,
         ):
             self.checker.visit_call(dtype_call)