better shared support

Author: pmp-p

.github/workflows/ci.yml

@@ -46,13 +46,13 @@ jobs:
         bash -c "./python-wasm-sdk.sh"
 
     - name: Upload sdk to Github artifacts
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3.1.1
       with:
         path: /tmp/sdk
 
     - name: Upload sdk to Github Releases
       if: github.event_name == 'release'
-      uses: svenstaro/upload-release-action@2.2.1
+      uses: svenstaro/upload-release-action@2.3.0
       with:
         repo_token: ${{ secrets.GITHUB_TOKEN }}
         file: /tmp/sdk/*

python-wasm-sdk.sh

@@ -29,12 +29,11 @@ do
 
     if [ -f ${SDKROOT}/dev ]
     then
-        rm ${SDKROOT}/emsdk/.completed
+        rm ${SDKROOT}/emsdk/.complete
     else
         rm -rf ${SDKROOT}/*
     fi
 
-
     cp -Rf * ${SDKROOT}/
 
     if cd ${SDKROOT}/

scripts/emsdk-fetch.sh

@@ -13,7 +13,7 @@ then
 " 1>&2
     else
         # emsdk could have been deleted for full rebuild
-        rm emsdk/.completed
+        rm emsdk/.complete
 
         if git clone --no-tags --depth 1 --single-branch --branch main https://github.com/emscripten-core/emsdk.git
         then
@@ -48,7 +48,7 @@ then
 
     export EMSDK_PYTHON=$SYS_PYTHON
 
-    if [ -f emsdk/.completed ]
+    if [ -f emsdk/.complete ]
     then
         echo "
         * emsdk prereq ok
@@ -151,10 +151,11 @@ for arg do
     else
         if \$IS_SHARED
         then
-            if echo "$arg"|grep -q -F .so\$
+            if echo "\$arg"|grep -q -F .so
             then
                 PY_MODULE=true
-                SHARED_TARGET=$arg
+                SHARED_TARGET=\$arg
+                SHARED="-sSIDE_MODULE"
             fi
         fi
     fi
@@ -200,10 +201,13 @@ $EMSDK_PYTHON -E \$0.py "\$@"
 END
 
         chmod +x emsdk/upstream/emscripten/em*
-        touch emsdk/.completed
+        touch emsdk/.complete
         sync
     fi
 
+    # EM_PKG_CONFIG_PATH ?
+    # https://emscripten.org/docs/compiling/Building-Projects.html#pkg-config
+
     export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig"
 
     if echo $PATH|grep -q $EMSDK/upstream/emscripten/system/bin