Skip to content

Commit 9d69a53

Browse files
authored
Merge pull request #2584 from Starbuck5/raise-minimum-sdl-version-2_0_10
Raise minimum SDL version to 2.0.10
2 parents b01e892 + 56fe66e commit 9d69a53

File tree

7 files changed

+7
-53
lines changed

7 files changed

+7
-53
lines changed

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ Dependency versions:
140140
+----------+------------------------+
141141
| CPython | >= 3.8 (Or use PyPy3) |
142142
+----------+------------------------+
143-
| SDL | >= 2.0.9 |
143+
| SDL | >= 2.0.10 |
144144
+----------+------------------------+
145145
| SDL_mixer| >= 2.0.4 |
146146
+----------+------------------------+

docs/readmes/README.es.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ Versiones de dependencia:
118118
+----------+-----------------------------+
119119
| CPython | >= 3.8 (Ou utiliser PyPy3) |
120120
+----------+-----------------------------+
121-
| SDL | >= 2.0.9 |
121+
| SDL | >= 2.0.10 |
122122
+----------+-----------------------------+
123123
| SDL_mixer| >= 2.0.4 |
124124
+----------+-----------------------------+

docs/readmes/README.fa.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ Dependencies (وابستگی ها)
190190
+----------+------------------------+
191191
| CPython | >= 3.8 (Or use PyPy3) |
192192
+----------+------------------------+
193-
| SDL | >= 2.0.9 |
193+
| SDL | >= 2.0.10 |
194194
+----------+------------------------+
195195
| SDL_mixer| >= 2.0.4 |
196196
+----------+------------------------+

docs/readmes/README.fr.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ Versions des dépendances:
147147
+----------+-----------------------------+
148148
| CPython | >= 3.8 (Ou utiliser PyPy3) |
149149
+----------+-----------------------------+
150-
| SDL | >= 2.0.9 |
150+
| SDL | >= 2.0.10 |
151151
+----------+-----------------------------+
152152
| SDL_mixer| >= 2.0.4 |
153153
+----------+-----------------------------+

docs/readmes/README.zh-cn.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ pygame显然依赖于SDL和Python。此外pygame还嵌入了几个较小的库
109109
+----------+------------------------+
110110
| CPython | >= 3.8 (或 PyPy3) |
111111
+----------+------------------------+
112-
| SDL | >= 2.0.9 |
112+
| SDL | >= 2.0.10 |
113113
+----------+------------------------+
114114
| SDL_mixer| >= 2.0.4 |
115115
+----------+------------------------+

src_c/pgcompat_rect.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,6 @@
33

44
#include <SDL.h>
55

6-
#if !(SDL_VERSION_ATLEAST(2, 0, 10))
7-
typedef struct SDL_FRect {
8-
float x, y;
9-
float w, h;
10-
} SDL_FRect;
11-
12-
typedef struct SDL_FPoint {
13-
float x;
14-
float y;
15-
} SDL_FPoint;
16-
17-
#endif /* !(SDL_VERSION_ATLEAST(2, 0, 10)) */
18-
196
/* SDL 2.0.22 provides some utility functions for FRects */
207
#if !(SDL_VERSION_ATLEAST(2, 0, 22))
218

src_c/surface.c

Lines changed: 2 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -263,39 +263,6 @@ pg_DisplayFormat(SDL_Surface *surface);
263263
static int
264264
_PgSurface_SrcAlpha(SDL_Surface *surf);
265265

266-
#if !SDL_VERSION_ATLEAST(2, 0, 10)
267-
static Uint32
268-
pg_map_rgb(SDL_Surface *surf, Uint8 r, Uint8 g, Uint8 b)
269-
{
270-
/* SDL_MapRGB() returns wrong values for color keys
271-
for indexed formats since since alpha = 0 */
272-
Uint32 key;
273-
if (!surf->format->palette)
274-
return SDL_MapRGB(surf->format, r, g, b);
275-
if (!SDL_GetColorKey(surf, &key)) {
276-
Uint8 keyr, keyg, keyb;
277-
SDL_GetRGB(key, surf->format, &keyr, &keyg, &keyb);
278-
if (r == keyr && g == keyg && b == keyb)
279-
return key;
280-
}
281-
else
282-
SDL_ClearError();
283-
return SDL_MapRGBA(surf->format, r, g, b, SDL_ALPHA_OPAQUE);
284-
}
285-
286-
static Uint32
287-
pg_map_rgba(SDL_Surface *surf, Uint8 r, Uint8 g, Uint8 b, Uint8 a)
288-
{
289-
if (!surf->format->palette)
290-
return SDL_MapRGBA(surf->format, r, g, b, a);
291-
return pg_map_rgb(surf, r, g, b);
292-
}
293-
#else /* SDL_VERSION_ATLEAST(2, 0, 10) */
294-
#define pg_map_rgb(surf, r, g, b) SDL_MapRGB((surf)->format, (r), (g), (b))
295-
#define pg_map_rgba(surf, r, g, b, a) \
296-
SDL_MapRGBA((surf)->format, (r), (g), (b), (a))
297-
#endif /* SDL_VERSION_ATLEAST(2, 0, 10) */
298-
299266
static PyGetSetDef surface_getsets[] = {
300267
{"_pixels_address", (getter)surf_get_pixels_address, NULL,
301268
"pixel buffer address (readonly)", NULL},
@@ -976,7 +943,7 @@ surf_map_rgb(PyObject *self, PyObject *args)
976943

977944
SURF_INIT_CHECK(surf)
978945

979-
color = pg_map_rgba(surf, rgba[0], rgba[1], rgba[2], rgba[3]);
946+
color = SDL_MapRGBA(surf->format, rgba[0], rgba[1], rgba[2], rgba[3]);
980947
return PyLong_FromLong(color);
981948
}
982949

@@ -1604,7 +1571,7 @@ surf_convert(pgSurfaceObject *self, PyObject *args)
16041571
}
16051572

16061573
if (has_colorkey) {
1607-
colorkey = pg_map_rgba(newsurf, key_r, key_g, key_b, key_a);
1574+
colorkey = SDL_MapRGBA(newsurf->format, key_r, key_g, key_b, key_a);
16081575
if (SDL_SetColorKey(newsurf, SDL_TRUE, colorkey) != 0) {
16091576
PyErr_SetString(pgExc_SDLError, SDL_GetError());
16101577
SDL_FreeSurface(newsurf);

0 commit comments

Comments
 (0)