Skip to content

Commit 7d5c5f1

Browse files
committed
add comment explaining urllib3 downgrade
1 parent eb87abe commit 7d5c5f1

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.circleci/config.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ jobs:
3434
- CIBW_SKIP: '*-musllinux_*'
3535
- CIBW_MANYLINUX_AARCH64_IMAGE: manylinux2014_base_aarch64
3636
- CIBW_MANYLINUX_PYPY_AARCH64_IMAGE: manylinux2014_base_aarch64
37+
# urllib3 2.0.0+ needs a newer OpenSSL version than what the python 3.7 build in
38+
# the image has. So downgrade urllib3 for now, until we drop python 3.7 (after
39+
# which there will be no need to downgrade)
3740
- CIBW_BEFORE_BUILD: pip install Sphinx"<7.2.0" urllib3"<2.0.0" && python setup.py docs
3841
- CIBW_TEST_COMMAND: python -m pygame.tests -v --exclude opengl,music,timing --time_out 300
3942
- CIBW_BUILD_VERBOSITY: 2

.github/workflows/build-manylinux.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ jobs:
6161
CIBW_SKIP: '*-musllinux_*'
6262

6363
# command that runs before every build
64+
# urllib3 2.0.0+ needs a newer OpenSSL version than what the python 3.7 build in
65+
# the image has. So downgrade urllib3 for now, until we drop python 3.7 (after
66+
# which there will be no need to downgrade)
6467
CIBW_BEFORE_BUILD: |
6568
pip install Sphinx"<7.2.0" urllib3"<2.0.0"
6669
python setup.py docs

0 commit comments

Comments
 (0)