defer isave_as and isave_book_as roll-out

Author: chfw

CHANGELOG.rst

@@ -1,13 +1,21 @@
 Change log
 ================================================================================
 
+0.1.1 - deferred
+--------------------------------------------------------------------------------
+
+Added
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+
+#. To bring isave_as and isave_book_as to web clients
+
 0.1.0 - unreleased
 --------------------------------------------------------------------------------
 
 Added
 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
-#. To bring iget_array, iget_records, isave_as and isave_book_as to web clients
+#. To bring iget_array, iget_records to web clients
 #. To facilitate the use of pyexcel-handsontable, pyexcel-pygal
 
 0.0.11 - 04.03.2017

pyexcel_webio/__init__.py

@@ -165,34 +165,6 @@ def save_to_database(self, session=None, table=None,
         params['dest_auto_commit'] = auto_commit
         pe.save_as(**params)
 
-    def isave_to_database(self, session=None, table=None,
-                          initializer=None, mapdict=None,
-                          auto_commit=True,
-                          **keywords):
-        """
-        Save data from a sheet to database
-
-        :param session: a SQLAlchemy session
-        :param table: a database table
-        :param initializer: a custom table initialization function if
-                            you have one
-        :param mapdict: the explicit table column names if your excel
-                        data do not have the exact column names
-        :param keywords: additional keywords to
-                         :meth:`pyexcel.Sheet.save_to_database`
-        """
-        params = self.get_params(**keywords)
-        if 'name_columns_by_row' not in params:
-            params['name_columns_by_row'] = 0
-        if 'name_rows_by_column' not in params:
-            params['name_rows_by_column'] = -1
-        params['dest_session'] = session
-        params['dest_table'] = table
-        params['dest_initializer'] = initializer
-        params['dest_mapdict'] = mapdict
-        params['dest_auto_commit'] = auto_commit
-        pe.isave_as(**params)
-
     def get_book(self, **keywords):
         """Get a instance of :class:`Book` from the file
 
@@ -236,31 +208,6 @@ def save_book_to_database(self, session=None, tables=None,
         params['dest_auto_commit'] = auto_commit
         pe.save_book_as(**params)
 
-    def isave_book_to_database(self, session=None, tables=None,
-                               initializers=None, mapdicts=None,
-                               auto_commit=True, **keywords):
-        """
-        Save a big book into database
-
-        :param session: a SQLAlchemy session
-        :param tables: a list of database tables
-        :param initializers: a list of model
-                             initialization functions.
-        :param mapdicts: a list of explicit table column names
-                         if your excel data sheets do not have
-                         the exact column names
-        :param keywords: additional keywords to
-                         :meth:`pyexcel.Book.save_to_database`
-
-        """
-        params = self.get_params(**keywords)
-        params['dest_session'] = session
-        params['dest_tables'] = tables
-        params['dest_initializers'] = initializers
-        params['dest_mapdicts'] = mapdicts
-        params['dest_auto_commit'] = auto_commit
-        pe.isave_book_as(**params)
-
 
 class ExcelInputInMultiDict(ExcelInput):
     """

tests/test_webio.py

@@ -97,6 +97,11 @@ def test_get_array(self):
         array = myinput.get_array(file_name=self.testfile)
         assert array == self.data
 
+    def test_iget_array(self):
+        myinput = TestInput()
+        array = myinput.iget_array(file_name=self.testfile)
+        assert list(array) == self.data
+
     def test_get_dict(self):
         myinput = TestInput()
         result = myinput.get_dict(file_name=self.testfile)
@@ -114,6 +119,14 @@ def test_get_records(self):
             {"X": 4, "Y": 5, "Z": 6}
         ]
 
+    def test_iget_records(self):
+        myinput = TestInput()
+        result = myinput.get_records(file_name=self.testfile)
+        assert list(result) == [
+            {"X": 1, "Y": 2, "Z": 3},
+            {"X": 4, "Y": 5, "Z": 6}
+        ]
+
     def test_save_to_database(self):
         Base.metadata.drop_all(engine)
         Base.metadata.create_all(engine)