fix #5: make this question as an feature

Author: chfw

django_excel/__init__.py

@@ -116,7 +116,17 @@ def new_file(self, file_name, *args, **kwargs):
             self.content_type_extra)
 
 
-webio.ExcelResponse = HttpResponse
+def make_response(content, content_type, status, file_name=None):
+    """
+    Custom response function that is called by pyexcel-webio
+    """
+    response = HttpResponse(content, content_type=content_type, status=status)
+    if file_name:
+        response["Content-Disposition"] = "attachment; filename=%s" % (file_name)
+    return response
+
+
+webio.ExcelResponse = make_response
 
 
 from pyexcel_webio import (
@@ -129,7 +139,8 @@ def new_file(self, file_name, *args, **kwargs):
 )
 
 
-def make_response_from_a_table(model, file_type, status=200, **keywords):
+def make_response_from_a_table(model, file_type,
+                               status=200, file_name=None, **keywords):
     """
     Produce a single sheet Excel book of *file_type*
 
@@ -138,10 +149,11 @@ def make_response_from_a_table(model, file_type, status=200, **keywords):
     :param status: same as :meth:`~django_excel.make_response`
     """
     sheet = pe.get_sheet(model=model, **keywords)
-    return make_response(sheet, file_type, status, **keywords)
+    return make_response(sheet, file_type, status, file_name=file_name, **keywords)
 
 
-def make_response_from_tables(models, file_type, status=200, **keywords):
+def make_response_from_tables(models, file_type,
+                              status=200, file_name=None, **keywords):
     """
     Produce a multiple sheet Excel book of *file_type*. It becomes the same
     as :meth:`~django_excel.make_response_from_a_table` if you pass *tables*
@@ -152,4 +164,4 @@ def make_response_from_tables(models, file_type, status=200, **keywords):
     :param status: same as :meth:`~django_excel.make_response`
     """
     book = pe.get_book(models=models, **keywords)
-    return make_response(book, file_type, status, **keywords)
+    return make_response(book, file_type, status, file_name=file_name, **keywords)

requirements.txt

@@ -1,3 +1,3 @@
 pyexcel>=0.1.4
-pyexcel-webio>=0.0.2
+pyexcel-webio>=0.0.5
 Django>=1.7.1

setup.py

@@ -8,11 +8,12 @@
 with open("README.rst", 'r') as readme:
     README_txt = readme.read()
 
-with open("requirements.txt", 'r') as requirements_txt:
-    lines = requirements_txt.readlines()
-    lines = map(lambda x: x.rstrip(), lines)
-    dependencies = lines
-
+dependencies=[
+    'pyexcel>=0.1.4',
+    'pyexcel-webio>=0.0.5',
+    'Django>=1.7.1'
+]
+    
 with open("VERSION", "r") as version:
     version_txt = version.read().rstrip()
 

testResponse.py

@@ -217,6 +217,7 @@ def testCustomExport(self):
 class ExcelResponseUsingFileTestCase(ExcelResponseTestCase):
     pass
 
+
 @override_settings(FILE_UPLOAD_MAX_MEMORY_SIZE=1)
 class DatabaseOperationsUsingFileTestCase(DatabaseOperationsTestCase):
     pass

test_requirements.txt

@@ -5,6 +5,6 @@ python-coveralls
 coverage==3.7.1
 pyexcel-xls
 pyexcel-xlsx
-https://github.com/T0ha/ezodf/archive/2c69103e6c0715adb0e36562cb2e6325fd776112.zip
 pyexcel-ods3
 lxml
+https://github.com/pyexcel/pyexcel-webio/archive/master.zip