Skip to content

Commit ee72978

Browse files
committed
Review feedback
performance -> accel jax move to extras feature spelling
1 parent 7ef5ace commit ee72978

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

.github/workflows/ci.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
5252
# Bookend python versions
5353
pixi-env: ["test-all-deps-py311", "test-all-deps-py313"]
54-
pytest-adopts: [""]
54+
pytest-addopts: [""]
5555
include:
5656
# Minimum python version:
5757
- pixi-env: "test-bare-minimum"
@@ -67,12 +67,12 @@ jobs:
6767
- pixi-env: "test-all-but-dask"
6868
os: ubuntu-latest
6969
- pixi-env: "test-all-deps-py313"
70-
pytest-adopts: "flaky"
70+
pytest-addopts: "flaky"
7171
os: ubuntu-latest
7272
# The mypy tests must be executed using only 1 process in order to guarantee
7373
# predictable mypy output messages for comparison to expectations.
7474
- pixi-env: "test-all-mypy-py311"
75-
pytest-adopts: "mypy"
75+
pytest-addopts: "mypy"
7676
numprocesses: 1
7777
os: ubuntu-latest
7878
- pixi-env: "test-all-mypy-py313"
@@ -101,12 +101,12 @@ jobs:
101101
run: |
102102
echo "TODAY=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
103103
104-
if [[ "${{ matrix.pytest-adopts }}" != "" ]] ;
104+
if [[ "${{ matrix.pytest-addopts }}" != "" ]] ;
105105
then
106-
if [[ "${{ matrix.pytest-adopts }}" == "flaky" ]] ;
106+
if [[ "${{ matrix.pytest-addopts }}" == "flaky" ]] ;
107107
then
108108
echo "PYTEST_ADDOPTS=-m 'flaky or network' --run-flaky --run-network-tests -W default" >> $GITHUB_ENV
109-
elif [[ "${{ matrix.pytest-adopts }}" == "mypy" ]] ;
109+
elif [[ "${{ matrix.pytest-addopts }}" == "mypy" ]] ;
110110
then
111111
echo "PYTEST_ADDOPTS=-n 1 -m 'mypy' --run-mypy -W default" >> $GITHUB_ENV
112112
fi

pixi.toml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test-all-but-numba = { features = [
1717
"py313",
1818
"test",
1919
"backends",
20-
"performance",
20+
"accel",
2121
"dask",
2222
"plotting",
2323
"extras",
@@ -26,7 +26,7 @@ test-all-but-dask = { features = [
2626
"py312",
2727
"test",
2828
"backends",
29-
"performance",
29+
"accel",
3030
"numba",
3131
"plotting",
3232
"extras",
@@ -35,7 +35,7 @@ test-all-deps-py313 = { features = [
3535
"py313",
3636
"test",
3737
"backends",
38-
"performance",
38+
"accel",
3939
"numba",
4040
"dask",
4141
"plotting",
@@ -45,7 +45,7 @@ test-all-deps-py311 = { features = [
4545
"py311",
4646
"test",
4747
"backends",
48-
"performance",
48+
"accel",
4949
"numba",
5050
"dask",
5151
"plotting",
@@ -56,7 +56,7 @@ test-all-mypy-py311 = { features = [
5656
"py311",
5757
"test",
5858
"backends",
59-
"performance",
59+
"accel",
6060
"numba",
6161
"dask",
6262
"plotting",
@@ -68,7 +68,7 @@ test-all-mypy-py313 = { features = [
6868
"py313",
6969
"test",
7070
"backends",
71-
"performance",
71+
"accel",
7272
"numba",
7373
"dask",
7474
"plotting",
@@ -89,7 +89,7 @@ doc = { features = [
8989
"doc",
9090
"backends",
9191
"test",
92-
"performance",
92+
"accel",
9393
"plotting",
9494
"extras",
9595
], solve-group = "doc" }
@@ -164,17 +164,13 @@ numbagg = "*"
164164
dask = "*"
165165
distributed = "*"
166166

167-
[feature.performance.dependencies]
167+
[feature.accel.dependencies]
168168
flox = "*"
169169
bottleneck = "*"
170170
numexpr = "*"
171171
pyarrow = "*"
172172
opt_einsum = "*"
173173

174-
[feature.performance.pypi-dependencies]
175-
jax = "*"
176-
177-
178174
[feature.plotting.dependencies]
179175
cartopy = "*"
180176
matplotlib-base = "*"
@@ -198,6 +194,10 @@ cftime = "*"
198194
pint = "*"
199195
iris = "*"
200196

197+
[feature.extras.pypi-dependencies]
198+
# array
199+
jax = "*"
200+
201201
[feature.test.dependencies]
202202
pytest = "*"
203203
pytest-asyncio = "*"

0 commit comments

Comments
 (0)