MAINT: Fix flake8 complaints

bashtage · bashtage · commit 85f92103b6c3 · 2023-10-24T11:25:49.000+01:00
diff --git a/pandas_datareader/av/__init__.py b/pandas_datareader/av/__init__.py
@@ -70,18 +70,18 @@ def data_key(self):
     def _read_lines(self, out):
         try:
             df = pd.DataFrame.from_dict(out[self.data_key], orient="index")
-        except KeyError:
+        except KeyError as exc:
             if "Error Message" in out:
                 raise ValueError(
                     "The requested symbol {} could not be "
                     "retrieved. Check valid ticker"
                     ".".format(self.symbols)
-                )
+                ) from exc
             else:
                 raise RemoteDataError(
                     " Their was an issue from the data vendor "
                     "side, here is their response: {}".format(out)
-                )
+                ) from exc
         df = df[sorted(df.columns)]
         df.columns = [id[3:] for id in df.columns]
         return df
diff --git a/pandas_datareader/av/forex.py b/pandas_datareader/av/forex.py
@@ -56,7 +56,7 @@ def __init__(
                 "Please input a currency pair "
                 "formatted 'FROM/TO' or a list of "
                 "currency symbols"
-            )
+            ) from e
 
     @property
     def function(self):
@@ -88,8 +88,8 @@ def read(self):
     def _read_lines(self, out):
         try:
             df = pd.DataFrame.from_dict(out[self.data_key], orient="index")
-        except KeyError:
-            raise RemoteDataError()
+        except KeyError as exc:
+            raise RemoteDataError() from exc
         df.sort_index(ascending=True, inplace=True)
         df.index = [id[3:] for id in df.index]
         return df
diff --git a/pandas_datareader/base.py b/pandas_datareader/base.py
@@ -268,7 +268,7 @@ def _dl_mult_symbols(self, symbols):
                     passed.append(sym)
                 except (IOError, KeyError):
                     msg = "Failed to read symbol: {0!r}, replacing with NaN."
-                    warnings.warn(msg.format(sym), SymbolWarning)
+                    warnings.warn(msg.format(sym), SymbolWarning, stacklevel=2)
                     failed.append(sym)
 
         if len(passed) == 0:
@@ -286,10 +286,10 @@ def _dl_mult_symbols(self, symbols):
                 result = concat(stocks).unstack(level=0)
             result.columns.names = ["Attributes", "Symbols"]
             return result
-        except AttributeError:
+        except AttributeError as exc:
             # cannot construct a panel with just 1D nans indicating no data
             msg = "No data fetched using {0!r}"
-            raise RemoteDataError(msg.format(self.__class__.__name__))
+            raise RemoteDataError(msg.format(self.__class__.__name__)) from exc
 
 
 def _in_chunks(seq, size):
diff --git a/pandas_datareader/famafrench.py b/pandas_datareader/famafrench.py
@@ -88,7 +88,7 @@ def _read_one_data(self, url, params):
             else:
                 c = ["Count"]
             r = list(range(0, 105, 5))
-            params["names"] = ["Date"] + c + list(zip(r, r[1:]))
+            params["names"] = ["Date"] + c + list(zip(r, r[1:], strict=True))
 
             if self.symbols != "Prior_2-12_Breakpoints":
                 params["skiprows"] = 1
@@ -144,11 +144,11 @@ def get_available_datasets(self):
         """
         try:
             from lxml.html import document_fromstring
-        except ImportError:
+        except ImportError as exc:
             raise ImportError(
                 "Please install lxml if you want to use the "
                 "get_datasets_famafrench function"
-            )
+            ) from exc
 
         response = self.session.get(_URL + "data_library.html")
         root = document_fromstring(response.content)
diff --git a/pandas_datareader/fred.py b/pandas_datareader/fred.py
@@ -50,12 +50,12 @@ def fetch_data(url, name):
             )
             try:
                 return data.truncate(self.start, self.end)
-            except KeyError:  # pragma: no cover
+            except KeyError as exc:  # pragma: no cover
                 if data.iloc[3].name[7:12] == "Error":
                     raise IOError(
                         "Failed to get the data. Check that "
                         "{0!r} is a valid FRED series.".format(name)
-                    )
+                    ) from exc
                 raise
 
         df = concat(
diff --git a/pandas_datareader/iex/__init__.py b/pandas_datareader/iex/__init__.py
@@ -71,8 +71,8 @@ def _output_error(self, out):
         """
         try:
             content = json.loads(out.text)
-        except Exception:
-            raise TypeError("Failed to interpret response as JSON.")
+        except Exception as exc:
+            raise TypeError("Failed to interpret response as JSON.") from exc
 
         for key, string in content.items():
             e = "IEX Output error encountered: {}".format(string)
diff --git a/pandas_datareader/iex/stats.py b/pandas_datareader/iex/stats.py
@@ -23,8 +23,9 @@ def __init__(
         import warnings
 
         warnings.warn(
-            "Daily statistics is not working due to issues with the " "IEX API",
+            "Daily statistics is not working due to issues with the IEX API",
             UnstableAPIWarning,
+            stacklevel=2,
         )
         self.curr_date = start
         super(DailySummaryReader, self).__init__(
diff --git a/pandas_datareader/io/jsdmx.py b/pandas_datareader/io/jsdmx.py
@@ -31,9 +31,9 @@ def read_jsdmx(path_or_buf):
 
     try:
         import simplejson as json
-    except ImportError:
+    except ImportError as exc:
         if sys.version_info[:2] < (2, 7):
-            raise ImportError("simplejson is required in python 2.6")
+            raise ImportError("simplejson is required in python 2.6") from exc
         import json
 
     if isinstance(jdata, dict):
diff --git a/pandas_datareader/io/sdmx.py b/pandas_datareader/io/sdmx.py
@@ -53,11 +53,11 @@ def read_sdmx(path_or_buf, dtype="float64", dsd=None):
 
     try:
         structure = _get_child(root, _MESSAGE + "Structure")
-    except ValueError:
+    except ValueError as exc:
         # get zipped path
         result = list(root.iter(_COMMON + "Text"))[1].text
         if not result.startswith("http"):
-            raise ValueError(result)
+            raise ValueError(result) from exc
 
         for _ in range(60):
             # wait zipped data is prepared
@@ -72,7 +72,7 @@ def read_sdmx(path_or_buf, dtype="float64", dsd=None):
             "Unable to download zipped data within 60 secs, "
             "please download it manually from: {0}"
         )
-        raise ValueError(msg.format(result))
+        raise ValueError(msg.format(result)) from exc
 
     idx_name = structure.get("dimensionAtObservation")
     dataset = _get_child(root, _DATASET)
diff --git a/pandas_datareader/nasdaq_trader.py b/pandas_datareader/nasdaq_trader.py
@@ -41,15 +41,17 @@ def _download_nasdaq_symbols(timeout):
         ftp_session = FTP(_NASDAQ_FTP_SERVER, timeout=timeout)
         ftp_session.login()
     except all_errors as err:
-        raise RemoteDataError("Error connecting to %r: %s" % (_NASDAQ_FTP_SERVER, err))
+        raise RemoteDataError(
+            "Error connecting to %r: %s" % (_NASDAQ_FTP_SERVER, err)
+        ) from err
 
     lines = []
     try:
         ftp_session.retrlines("RETR " + _NASDAQ_TICKER_LOC, lines.append)
     except all_errors as err:
         raise RemoteDataError(
             "Error downloading from %r: %s" % (_NASDAQ_FTP_SERVER, err)
-        )
+        ) from err
     finally:
         ftp_session.close()
 
diff --git a/pandas_datareader/tests/test_bankofcanada.py b/pandas_datareader/tests/test_bankofcanada.py
@@ -42,7 +42,9 @@ def check_bankofcanada_inverted(self, code):
             date.today(),
         )
 
-        pairs = zip((1 / df)[symbol].tolist(), df_i[symbol_inverted].tolist())
+        pairs = zip(
+            (1 / df)[symbol].tolist(), df_i[symbol_inverted].tolist(), strict=True
+        )
         assert all(a - b < 0.01 for a, b in pairs)
 
     def test_bankofcanada_usd_count(self):
diff --git a/pandas_datareader/tests/test_base.py b/pandas_datareader/tests/test_base.py
@@ -23,9 +23,9 @@ def test_invalid_url(self):
             base._BaseReader([]).url
 
     def test_invalid_format(self):
+        b = base._BaseReader([])
+        b._format = "IM_NOT_AN_IMPLEMENTED_TYPE"
         with pytest.raises(NotImplementedError):
-            b = base._BaseReader([])
-            b._format = "IM_NOT_AN_IMPLEMENTED_TYPE"
             b._read_one_data("a", None)
 
     def test_default_start_date(self):
@@ -35,6 +35,6 @@ def test_default_start_date(self):
 
 class TestDailyBaseReader(object):
     def test_get_params(self):
+        b = base._DailyBaseReader()
         with pytest.raises(NotImplementedError):
-            b = base._DailyBaseReader()
             b._get_params()
diff --git a/pandas_datareader/tests/test_fred.py b/pandas_datareader/tests/test_fred.py
@@ -54,7 +54,7 @@ def test_fred_part2(self):
 
     def test_invalid_series(self):
         name = "NOT A REAL SERIES"
-        with pytest.raises(Exception):
+        with pytest.raises(Exception):  # noqa: B017
             web.get_data_fred(name)
 
     def test_fred_multi(self):  # pragma: no cover
diff --git a/pandas_datareader/tests/test_iex.py b/pandas_datareader/tests/test_iex.py
@@ -31,15 +31,13 @@ def test_false_ticker(self):
         df = get_last_iex("INVALID TICKER")
         assert df.shape[0] == 0
 
-    @pytest.mark.xfail(
-        reason="IEX daily history API is returning 500 as of " "Jan 2018"
-    )
+    @pytest.mark.xfail(reason="IEX daily history API is returning 500 as of Jan 2018")
     def test_daily(self):
-        with pytest.warns(UnstableAPIWarning):
+        with pytest.warns(UnstableAPIWarning, match="Daily statistics"):
             df = get_dailysummary_iex(
                 start=datetime(2017, 5, 5), end=datetime(2017, 5, 6)
             )
-            assert df["routedVolume"].iloc[0] == 39974788
+        assert df["routedVolume"].iloc[0] == 39974788
 
     def test_symbols(self):
         df = get_iex_symbols()
diff --git a/pandas_datareader/tests/test_iex_daily.py b/pandas_datareader/tests/test_iex_daily.py
@@ -25,17 +25,17 @@ def end(self):
         return datetime(2017, 5, 24)
 
     def test_iex_bad_symbol(self):
-        with pytest.raises(Exception):
+        with pytest.raises(Exception):  # noqa: B017
             web.DataReader("BADTICKER", "iex,", self.start, self.end)
 
     def test_iex_bad_symbol_list(self):
-        with pytest.raises(Exception):
+        with pytest.raises(Exception):  # noqa: B017
             web.DataReader(["AAPL", "BADTICKER"], "iex", self.start, self.end)
 
     def test_daily_invalid_date(self):
         start = datetime(2000, 1, 5)
         end = datetime(2017, 5, 24)
-        with pytest.raises(Exception):
+        with pytest.raises(Exception):  # noqa: B017
             web.DataReader(["AAPL", "TSLA"], "iex", start, end)
 
     def test_single_symbol(self):
diff --git a/pandas_datareader/tests/test_wb.py b/pandas_datareader/tests/test_wb.py
@@ -149,8 +149,8 @@ def test_wdi_download_error_handling(self):
             result = download(
                 country=cntry_codes, indicator=inds, start=2003, end=2004, errors="warn"
             )
-            assert isinstance(result, pd.DataFrame)
-            assert len(result), 2
+        assert isinstance(result, pd.DataFrame)
+        assert len(result), 2
 
         cntry_codes = ["USA"]
         inds = ["NY.GDP.PCAP.CD", "BAD_INDICATOR"]
@@ -169,8 +169,8 @@ def test_wdi_download_error_handling(self):
             result = download(
                 country=cntry_codes, indicator=inds, start=2003, end=2004, errors="warn"
             )
-            assert isinstance(result, pd.DataFrame)
-            assert len(result) == 2
+        assert isinstance(result, pd.DataFrame)
+        assert len(result) == 2
 
     def test_wdi_download_w_retired_indicator(self):
         cntry_codes = ["CA", "MX", "US"]
@@ -201,8 +201,8 @@ def test_wdi_download_w_retired_indicator(self):
             # get caught above
             # or the WB API changed somehow in a really
             # unexpected way.
-            if len(result) > 0:  # pragma: no cover
-                pytest.skip("Invalid results")
+        if len(result) > 0:  # pragma: no cover
+            pytest.skip("Invalid results")
 
     def test_wdi_download_w_crash_inducing_countrycode(self):
         cntry_codes = ["CA", "MX", "US", "XXX"]
@@ -217,12 +217,12 @@ def test_wdi_download_w_crash_inducing_countrycode(self):
                 errors="ignore",
             )
 
-            # If it ever gets here, it means the country code XXX
-            # got used by WB
-            # or the WB API changed somehow in a really
-            # unexpected way.
-            if len(result) > 0:  # pragma: no cover
-                pytest.skip("Invalid results")
+        # If it ever gets here, it means the country code XXX
+        # got used by WB
+        # or the WB API changed somehow in a really
+        # unexpected way.
+        if len(result) > 0:  # pragma: no cover
+            pytest.skip("Invalid results")
 
     def test_wdi_get_countries(self):
         result1 = get_countries()
diff --git a/pandas_datareader/tests/yahoo/test_yahoo.py b/pandas_datareader/tests/yahoo/test_yahoo.py
@@ -34,7 +34,7 @@ def test_yahoo_fails(self):
         start = datetime(2010, 1, 1)
         end = datetime(2013, 1, 27)
 
-        with pytest.raises(Exception):
+        with pytest.raises(Exception):  # noqa: B017
             web.DataReader("NON EXISTENT TICKER", "yahoo", start, end)
 
     def test_get_quote_series(self):
diff --git a/pandas_datareader/wb.py b/pandas_datareader/wb.py
@@ -589,7 +589,9 @@ def __init__(
                 raise ValueError("Invalid Country Code(s): %s" % tmp)
             if errors == "warn":
                 warnings.warn(
-                    "Non-standard ISO " "country codes: %s" % tmp, UserWarning
+                    "Non-standard ISO country codes: %s" % tmp,
+                    UserWarning,
+                    stacklevel=2,
                 )
 
         freq_symbols = ["M", "Q", "A", None]
@@ -653,9 +655,9 @@ def _read(self):
             except ValueError as e:
                 msg = str(e) + " Indicator: " + indicator
                 if self.errors == "raise":
-                    raise ValueError(msg)
+                    raise ValueError(msg) from e
                 elif self.errors == "warn":
-                    warnings.warn(msg)
+                    warnings.warn(msg, stacklevel=2)
 
         # Confirm we actually got some data, and build Dataframe
         if len(data) > 0:
diff --git a/pandas_datareader/yahoo/daily.py b/pandas_datareader/yahoo/daily.py
@@ -151,9 +151,9 @@ def _read_one_data(self, url, params):
         try:
             j = json.loads(re.search(ptrn, resp.text, re.DOTALL).group(1))
             data = j["context"]["dispatcher"]["stores"]["HistoricalPriceStore"]
-        except KeyError:
+        except KeyError as exc:
             msg = "No data fetched for symbol {} using {}"
-            raise RemoteDataError(msg.format(symbol, self.__class__.__name__))
+            raise RemoteDataError(msg.format(symbol, self.__class__.__name__)) from exc
 
         # price data
         prices = DataFrame(data["prices"])
diff --git a/pandas_datareader/yahoo/fx.py b/pandas_datareader/yahoo/fx.py
@@ -103,7 +103,7 @@ def _dl_mult_symbols(self, symbols):
                 passed.append(sym)
             except IOError:
                 msg = "Failed to read symbol: {0!r}, replacing with NaN."
-                warnings.warn(msg.format(sym), SymbolWarning)
+                warnings.warn(msg.format(sym), SymbolWarning, stacklevel=2)
                 failed.append(sym)
 
         if len(passed) == 0:
diff --git a/pandas_datareader/yahoo/options.py b/pandas_datareader/yahoo/options.py
@@ -142,8 +142,10 @@ def _option_from_url(self, url):
         try:
             calls = result["options"]["calls"]
             puts = result["options"]["puts"]
-        except IndexError:
-            raise RemoteDataError("Option json not available " "for url: %s" % url)
+        except IndexError as exc:
+            raise RemoteDataError(
+                "Option json not available " "for url: %s" % url
+            ) from exc
 
         self.underlying_price = (
             result["quote"]["regularMarketPrice"]
@@ -561,7 +563,7 @@ def get_forward_data(
                       on Yahoo and may change.
 
         """
-        warnings.warn("get_forward_data() is deprecated", FutureWarning)
+        warnings.warn("get_forward_data() is deprecated", FutureWarning, stacklevel=2)
         end_date = dt.date.today() + MonthEnd(months)
         dates = [date for date in self.expiry_dates if date <= end_date.date()]
         data = self._get_data_in_date_range(dates, call=call, put=put)
diff --git a/pyproject.toml b/pyproject.toml
