Merge pull request #542 from pydata/test-numpy-1.26

Test numpy 1.26

Author: lshaw8317

.github/workflows/build.yml

@@ -7,7 +7,7 @@ permissions:
 
 jobs:
   build_wheels:
-    name: Build wheels on ${{ matrix.os }} for ${{ matrix.arch }}
+    name: Build and test on ${{ matrix.os }}${{ matrix.numpy-version && format(' (numpy {0})', matrix.numpy-version) || '' }} for ${{ matrix.arch }}
     runs-on: ${{ matrix.runs-on || matrix.os }}
     permissions:
       contents: write
@@ -24,6 +24,12 @@ jobs:
             arch: x86_64
             artifact_name: "linux-x86_64"
 
+            # Linux x86_64 with numpy 1.23
+          - os: ubuntu-latest
+            arch: x86_64
+            artifact_name: "linux-x86_64_numpy1_23"
+            numpy-version: "1.26"
+
           # Linux ARM64 builds (native runners)
           - os: ubuntu-24.04-arm
             arch: aarch64
@@ -44,7 +50,19 @@ jobs:
       - uses: actions/setup-python@v3
         name: Install Python
         with:
-          python-version: '3.x'
+          python-version: '3.12'
+
+      - name: Install specific numpy version
+        if: matrix.numpy-version
+        run: pip install "numpy==${{ matrix.numpy-version }}.*"
+
+      - name: Local Build
+        run: pip install -e .
+
+      - name: Test
+        run: |
+          pip install pytest
+          python -m pytest
 
       - name: Build wheels
         uses: pypa/cibuildwheel@v3.1.3

numexpr/tests/test_numexpr.py

@@ -963,7 +963,11 @@ def test_expressions(
     # "overflows" or "divide by zero" in plain eval().
     warnings.simplefilter("ignore")
     try:
-        npval = eval(expr, globals(), locals())
+        npexpr = expr
+        if "sign" in expr and dtype==complex and np.__version__<"2.0":
+            #definition of sign changed in numpy 2.0 for complex numbers
+            npexpr = expr.replace("sign(b+c)", "(b+c)/abs(b+c)")
+        npval = eval(npexpr, globals(), locals())
     except Exception as ex:
         np_exception = ex
         npval = None

requirements.txt

@@ -1 +1 @@
-numpy >= 1.23.0 # keep in sync with NPY_TARGET_VERSION (setup.py)
+numpy >= 1.26.0 # keep in sync with NPY_TARGET_VERSION (setup.py)