Commit 93f136c
Adds instrumentation to PUT ops in the CLI (apache#18139)
## Which issue does this PR close?
This does not fully close, but is an incremental building block
component for:
- apache#17207
The full context of how this code is likely to progress can be seen in
the POC for this effort:
- apache#17266
## Rationale for this change
Further fills out the missing methods that have yet to be instrumented
in the instrumented object store.
## What changes are included in this PR?
- Adds instrumentation around put_opts
- Adds instrumentation around put_multipart
- Adds tests for newly instrumented methods
## Are these changes tested?
Yes. Unit tests have been added for the new methods
Example output:
```sql
DataFusion CLI v50.2.0
> CREATE EXTERNAL TABLE
test(a bigint, b bigint)
STORED AS parquet LOCATION '../../test_table/';
0 row(s) fetched.
Elapsed 0.003 seconds.
> \object_store_profiling trace
ObjectStore Profile mode set to Trace
> INSERT INTO test values (1, 2), (3, 4);
+-------+
| count |
+-------+
| 2 |
+-------+
1 row(s) fetched.
Elapsed 0.007 seconds.
Object Store Profiling
Instrumented Object Store: instrument_mode: Trace, inner: LocalFileSystem(file:///)
2025-10-17T19:02:15.440246215+00:00 operation=List path=home/blake/open_source_src/datafusion-BlakeOrth/test_table
2025-10-17T19:02:15.444096012+00:00 operation=Put duration=0.000249s size=815 path=home/blake/open_source_src/datafusion-BlakeOrth/test_table/a9pjKBxSOtXZobJO_0.parquet
Summaries:
List
count: 1
Put
count: 1
duration min: 0.000249s
duration max: 0.000249s
duration avg: 0.000249s
size min: 815 B
size max: 815 B
size avg: 815 B
size sum: 815 B
>
```
(note: I have no idea how to exercise/show a multi-part put operation,
or if DataFusion even utilizes multipart puts for large files)
## Are there any user-facing changes?
No-ish
cc @alamb
---------
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>1 parent 0ddc82e commit 93f136c
1 file changed
+128
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
124 | 172 | | |
125 | 173 | | |
126 | 174 | | |
| |||
209 | 257 | | |
210 | 258 | | |
211 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
212 | 264 | | |
213 | 265 | | |
214 | 266 | | |
| |||
217 | 269 | | |
218 | 270 | | |
219 | 271 | | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
220 | 276 | | |
221 | 277 | | |
222 | 278 | | |
| |||
269 | 325 | | |
270 | 326 | | |
271 | 327 | | |
272 | | - | |
| 328 | + | |
273 | 329 | | |
274 | 330 | | |
275 | 331 | | |
| |||
599 | 655 | | |
600 | 656 | | |
601 | 657 | | |
| 658 | + | |
| 659 | + | |
602 | 660 | | |
603 | 661 | | |
604 | 662 | | |
| |||
741 | 799 | | |
742 | 800 | | |
743 | 801 | | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
744 | 868 | | |
745 | 869 | | |
746 | 870 | | |
| |||
819 | 943 | | |
820 | 944 | | |
821 | 945 | | |
822 | | - | |
| 946 | + | |
823 | 947 | | |
824 | 948 | | |
825 | 949 | | |
| |||
834 | 958 | | |
835 | 959 | | |
836 | 960 | | |
837 | | - | |
838 | | - | |
| 961 | + | |
| 962 | + | |
839 | 963 | | |
840 | 964 | | |
841 | 965 | | |
| |||
0 commit comments