Add a missing std::move in numpy.h (#4005)

Skylion007 · web-flow · commit 0964a9093a72 · 2022-06-14T14:20:26.000-04:00
diff --git a/include/pybind11/numpy.h b/include/pybind11/numpy.h
@@ -1409,7 +1409,7 @@ PYBIND11_NOINLINE void register_structured_dtype(any_container<field_descriptor>
     }
 
     auto tindex = std::type_index(tinfo);
-    numpy_internals.registered_dtypes[tindex] = {dtype_ptr, format_str};
+    numpy_internals.registered_dtypes[tindex] = {dtype_ptr, std::move(format_str)};
     get_internals().direct_conversions[tindex].push_back(direct_converter);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1409,7 +1409,7 @@ PYBIND11_NOINLINE void register_structured_dtype(any_container<field_descriptor>`
`1409`	`1409`	`}`
`1410`	`1410`
`1411`	`1411`	`auto tindex = std::type_index(tinfo);`
`1412`		`- numpy_internals.registered_dtypes[tindex] = {dtype_ptr, format_str};`
	`1412`	`+ numpy_internals.registered_dtypes[tindex] = {dtype_ptr, std::move(format_str)};`
`1413`	`1413`	`get_internals().direct_conversions[tindex].push_back(direct_converter);`
`1414`	`1414`	`}`
`1415`	`1415`