-
Notifications
You must be signed in to change notification settings - Fork 33
enh(policy): Add discussion of package length #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes were made by an autoformatter? Either way, everything in here looks good and should probably add markdown formatting checks to CI.
|
|
||
| ### Package size and scholarly effort | ||
|
|
||
| PyOpenSci reviews packages that represent substantial scholarly effort and provide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| PyOpenSci reviews packages that represent substantial scholarly effort and provide | |
| pyOpenSci reviews packages that represent substantial scholarly effort and provide |
| The final decision on whether a package represents sufficient scholarly effort | ||
| rests with the editor and will be made on a case-by-case basis. | ||
|
|
||
| ```{note} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ```{note} | |
| :::{note} |
just for consistency as we use colon fences throughout (works either way tho!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lwasser I think this was changed on save with the autoformatter I was using. Is there a way to have colon fences enforced through autoformatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eliotwrobson what are you using here on save? I think either we need a consistent linter for markdown or turn off linting on save-- otherwise this will keep happening every commit/PR
| Our more flexible approach allows us to support useful scientific packages | ||
| that may be outside JOSS scope while maintaining our partnership for | ||
| packages that meet both organizations' criteria. | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ``` | |
| ::: |
| ```{note} | ||
| **Relationship to JOSS requirements:** | ||
| The Journal of Open Source Software (JOSS) requires packages to have at least |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also link to JOSS policies here for "validation" .
| standards. This approach reduces the burden of a full review while ensuring the quality of the package | ||
| reflects its most recent version. | ||
|
|
||
| ```{note} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ```{note} | |
| :::{note} |
| but does not meet JOSS requirements (e.g., minimum lines of code), it will not be | ||
| eligible for JOSS fast-track review. See our [package scope guidelines](../about/package-scope.html#package-size-and-scholarly-effort) | ||
| for more details. | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ``` | |
| ::: |
| (coi)= | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| (coi)= | |
| (coi)= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably an autoformat thing here too. i think targets work with a line space but i'm not sure!
lwasser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes here!!
| minimum line count, we expect packages to demonstrate sufficient complexity and | ||
| functionality to warrant a comprehensive peer review. | ||
|
|
||
| **General expectations:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great additions
Summarized discussion in #351 and should be appropriate for closing the issue. Written using gen ai for summarizing.