Skip to content

Conversation

@eliotwrobson
Copy link
Contributor

Summarized discussion in #351 and should be appropriate for closing the issue. Written using gen ai for summarizing.

@eliotwrobson eliotwrobson requested a review from lwasser November 29, 2025 06:50
@eliotwrobson eliotwrobson self-assigned this Nov 29, 2025
@eliotwrobson eliotwrobson linked an issue Nov 29, 2025 that may be closed by this pull request
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes were made by an autoformatter? Either way, everything in here looks good and should probably add markdown formatting checks to CI.


### Package size and scholarly effort

PyOpenSci reviews packages that represent substantial scholarly effort and provide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PyOpenSci reviews packages that represent substantial scholarly effort and provide
pyOpenSci reviews packages that represent substantial scholarly effort and provide

The final decision on whether a package represents sufficient scholarly effort
rests with the editor and will be made on a case-by-case basis.

```{note}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```{note}
:::{note}

just for consistency as we use colon fences throughout (works either way tho!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwasser I think this was changed on save with the autoformatter I was using. Is there a way to have colon fences enforced through autoformatting?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliotwrobson what are you using here on save? I think either we need a consistent linter for markdown or turn off linting on save-- otherwise this will keep happening every commit/PR

Our more flexible approach allows us to support useful scientific packages
that may be outside JOSS scope while maintaining our partnership for
packages that meet both organizations' criteria.
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
:::

```{note}
**Relationship to JOSS requirements:**
The Journal of Open Source Software (JOSS) requires packages to have at least
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also link to JOSS policies here for "validation" .

standards. This approach reduces the burden of a full review while ensuring the quality of the package
reflects its most recent version.

```{note}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```{note}
:::{note}

but does not meet JOSS requirements (e.g., minimum lines of code), it will not be
eligible for JOSS fast-track review. See our [package scope guidelines](../about/package-scope.html#package-size-and-scholarly-effort)
for more details.
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
:::

Comment on lines 84 to 85
(coi)=

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(coi)=
(coi)=

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably an autoformat thing here too. i think targets work with a line space but i'm not sure!

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes here!!

@lwasser lwasser requested a review from a team December 1, 2025 18:15
minimum line count, we expect packages to demonstrate sufficient complexity and
functionality to warrant a comprehensive peer review.

**General expectations:**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POLICY: Lines of code in a package

4 participants