Skip to content

Commit f86b7a4

Browse files
committed
openvswitch: switch from WARN to pr_warn
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2163374 Upstream Status: linux.git commit fd954cc Author: Aaron Conole <aconole@redhat.com> Date: Tue Oct 25 06:50:17 2022 -0400 openvswitch: switch from WARN to pr_warn As noted by Paolo Abeni, pr_warn doesn't generate any splat and can still preserve the warning to the user that feature downgrade occurred. We likely cannot introduce other kinds of checks / enforcement here because syzbot can generate different genl versions to the datapath. Reported-by: syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com Fixes: 44da5ae ("openvswitch: Drop user features if old user space attempted to create datapath") Cc: Thomas Graf <tgraf@suug.ch> Signed-off-by: Aaron Conole <aconole@redhat.com> Acked-by: Ilya Maximets <i.maximets@ovn.org> Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Antoine Tenart <atenart@redhat.com>
1 parent 4149442 commit f86b7a4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/openvswitch/datapath.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1614,7 +1614,8 @@ static void ovs_dp_reset_user_features(struct sk_buff *skb,
16141614
if (IS_ERR(dp))
16151615
return;
16161616

1617-
WARN(dp->user_features, "Dropping previously announced user features\n");
1617+
pr_warn("%s: Dropping previously announced user features\n",
1618+
ovs_dp_name(dp));
16181619
dp->user_features = 0;
16191620
}
16201621

0 commit comments

Comments
 (0)