i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer

ahalaney · ahalaney · commit e7dada06d64f · 2023-01-25T09:46:22.000-06:00
Bugzilla: https://bugzilla.redhat.com/2164495 commit 7d8ccf4 Author: Wang Yufen <wangyufen@huawei.com> Date: Mon Nov 21 18:17:52 2022 +0800 i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer Fix to return a negative error code from the gi2c->err instead of 0. Fixes: d870355 ("i2c: qcom-geni: Add support for GPI DMA") Signed-off-by: Wang Yufen <wangyufen@huawei.com> Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasoluitons.com> Signed-off-by: Wolfram Sang <wsa@kernel.org> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i
 			dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n",
 				gi2c->cur->flags, gi2c->cur->addr);
 			gi2c->err = -ETIMEDOUT;
-			goto err;
 		}
 
 		if (gi2c->err) {

Original file line number	Diff line number	Diff line change
`@@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i`
`626`	`626`	`dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n",`
`627`	`627`	`gi2c->cur->flags, gi2c->cur->addr);`
`628`	`628`	`gi2c->err = -ETIMEDOUT;`
`629`		`- goto err;`
`630`	`629`	`}`
`631`	`630`
`632`	`631`	`if (gi2c->err) {`